From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBF8C3A5A1 for ; Wed, 28 Aug 2019 16:18:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6FEF2173E for ; Wed, 28 Aug 2019 16:18:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6FEF2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46JWB22fsMzDqCT for ; Thu, 29 Aug 2019 02:18:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=suse.de (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=msuchanek@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46JW7R0mSQzDqfp for ; Thu, 29 Aug 2019 02:15:46 +1000 (AEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A4527AFE8; Wed, 28 Aug 2019 16:15:42 +0000 (UTC) Date: Wed, 28 Aug 2019 18:15:40 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Christoph Hellwig Subject: Re: [PATCH 1/4] fs: always build llseek. Message-ID: <20190828181540.21fa33a4@naga> In-Reply-To: <20190828151552.GA16855@infradead.org> References: <80b1955b86fb81e4642881d498068b5a540ef029.1566936688.git.msuchanek@suse.de> <20190828151552.GA16855@infradead.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Neuling , "Eric W. Biederman" , David Hildenbrand , Greg Kroah-Hartman , Nicholas Piggin , linux-kernel@vger.kernel.org, Steven Rostedt , "Dmitry V. Levin" , Breno Leitao , Max Filippov , Hari Bathini , Paul Mackerras , Alexander Viro , Andrew Donnellan , linux-fsdevel@vger.kernel.org, Firoz Khan , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Allison Randal , Joel Stanley Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 28 Aug 2019 08:15:52 -0700 Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > > 64bit !COMPAT does not build because the llseek syscall is in the tables. > > Well, this will bloat thinkgs like 64-bit RISC-V for no good reason. > Please introduce a WANT_LSEEK like symbol that ppc64 can select instead. It also builds when llseek is marked as 32bit only in syscall.tbl It seems it was handled specially in some way before syscall.tbl was added, though (removed in ab66dcc76d6ab8fae9d69d149ae38c42605e7fc5) Thanks Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF36C3A5A4 for ; Wed, 28 Aug 2019 16:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4ED2B22DA7 for ; Wed, 28 Aug 2019 16:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbfH1QPo (ORCPT ); Wed, 28 Aug 2019 12:15:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:54576 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726400AbfH1QPo (ORCPT ); Wed, 28 Aug 2019 12:15:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A4527AFE8; Wed, 28 Aug 2019 16:15:42 +0000 (UTC) Date: Wed, 28 Aug 2019 18:15:40 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Christoph Hellwig Cc: Alexander Viro , Michael Neuling , David Hildenbrand , Steven Rostedt , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, Allison Randal , linux-kernel@vger.kernel.org, Nicholas Piggin , "Dmitry V. Levin" , Max Filippov , Paul Mackerras , Joel Stanley , Andrew Donnellan , Breno Leitao , Firoz Khan , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Hari Bathini , "Eric W. Biederman" Subject: Re: [PATCH 1/4] fs: always build llseek. Message-ID: <20190828181540.21fa33a4@naga> In-Reply-To: <20190828151552.GA16855@infradead.org> References: <80b1955b86fb81e4642881d498068b5a540ef029.1566936688.git.msuchanek@suse.de> <20190828151552.GA16855@infradead.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 28 Aug 2019 08:15:52 -0700 Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > > 64bit !COMPAT does not build because the llseek syscall is in the tables. > > Well, this will bloat thinkgs like 64-bit RISC-V for no good reason. > Please introduce a WANT_LSEEK like symbol that ppc64 can select instead. It also builds when llseek is marked as 32bit only in syscall.tbl It seems it was handled specially in some way before syscall.tbl was added, though (removed in ab66dcc76d6ab8fae9d69d149ae38c42605e7fc5) Thanks Michal