From: Daniel Vetter <daniel@ffwll.ch>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>,
"kenneth@whitecape.org" <kenneth@whitecape.org>,
"Auld, Matthew" <matthew.auld@intel.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+
Date: Thu, 29 Aug 2019 08:50:04 +0200 [thread overview]
Message-ID: <20190829065004.GG2112@phenom.ffwll.local> (raw)
In-Reply-To: <6c22439c4f38d0be6f8183bbe279c9e0f3db983b.camel@intel.com>
On Wed, Aug 28, 2019 at 08:31:27PM +0000, Souza, Jose wrote:
> On Wed, 2019-08-28 at 21:13 +0100, Chris Wilson wrote:
> > Quoting Souza, Jose (2019-08-28 21:11:53)
> > > Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> >
> > It's using a non-standard for i915 error code, and get_tiling is not
>
> Huum should it use ENOTSUPP then?!
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Per above "feature not supported" -> EOPNOTSUPP.
> > affected, it will always return LINEAR. You cannot set tiling as
>
> Following this set_tiling() LINEAR should be allowed too.
> I prefer the current approach of returning error.
I'm not seeing the value in keeping get_tiling supported. Either userspace
still uses the legacy backhannel and dri2, in which case it needs to be
fixed no matter what. Or it's using modifiers, in which case this is dead
code. Only other user I can think of is takeover for fastboot, but if you
get anything else than untiled it's also broken (we don't have an ioctl to
read out the modifiers, heck even all the planes, there's no getfb2).
So really not seeing the point in keeping that working.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-29 6:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 17:06 [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+ Daniel Vetter
2019-08-20 18:55 ` Chris Wilson
2019-08-20 19:06 ` Daniel Vetter
2019-08-20 19:25 ` Chris Wilson
2019-08-20 19:25 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-20 19:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-08-20 19:54 ` [PATCH] " Daniel Vetter
2019-08-20 20:57 ` Daniele Ceraolo Spurio
2019-08-21 13:55 ` Ville Syrjälä
2019-08-21 15:20 ` Daniel Vetter
2019-08-22 19:25 ` Jason Ekstrand
2019-08-28 20:11 ` Souza, Jose
2019-08-28 20:13 ` Chris Wilson
2019-08-28 20:31 ` Souza, Jose
2019-08-29 6:50 ` Daniel Vetter [this message]
2019-09-03 19:21 ` Souza, Jose
2019-09-04 14:29 ` Daniel Vetter
2019-09-04 14:31 ` Daniel Vetter
2019-09-04 19:05 ` Souza, Jose
2019-11-07 23:07 ` Brian Welty
2019-11-07 23:07 ` [Intel-gfx] " Brian Welty
2019-11-08 17:35 ` Daniel Vetter
2019-11-08 17:35 ` [Intel-gfx] " Daniel Vetter
2019-09-19 20:57 ` Daniele Ceraolo Spurio
2019-08-20 20:46 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: disable set/get_tiling ioctl on gen12+ (rev2) Patchwork
2019-08-20 21:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-21 12:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-08-29 14:18 ` ✓ Fi.CI.IGT: success " Patchwork
2019-09-04 19:56 ` Souza, Jose
2019-10-30 19:30 ` [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+ Jason Ekstrand
2019-10-30 19:30 ` [Intel-gfx] " Jason Ekstrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829065004.GG2112@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=kenneth@whitecape.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.