From: Gao Xiang <gaoxiang25@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org,
"Sasha Levin" <alexander.levin@microsoft.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org, yuchao0@huawei.com,
miaoxie@huawei.com, "Theodore Y. Ts'o" <tytso@mit.edu>,
"Eric Biggers" <ebiggers@kernel.org>,
"Zefan Li" <lizefan@huawei.com>
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging
Date: Thu, 29 Aug 2019 16:24:09 +0800 [thread overview]
Message-ID: <20190829082409.GA83154@architecture4> (raw)
In-Reply-To: <20190829070149.GA155353@architecture4>
Hi Christoph,
On Thu, Aug 29, 2019 at 03:01:49PM +0800, Gao Xiang wrote:
> Hi Christoph,
>
> On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote:
> > Can we please just review the damn thing and get it into the proper
> > tree? That whole concept of staging file systems just has been one
> > fricking disaster, including Greg just moving not fully reviewed ones
> > over like erofs just because he feels like it. I'm getting sick and
> > tired of this scheme.
>
> I just want to a word on EROFS stuff (I'm not suitable to comment
> on the current exfat implementation). Since EROFS stuff has been
> in staging tree for more than a year, anyone who wants to review
> it can review this filesystem at any time.
>
> EROFS is not just a homebrew or experimental fs for now, it has been
> widely used for many commerical smartphones, and we will upstream it
> to AOSP for more Android smartphones after it gets merged to upstream.
> I personally cc-ed you for a month, and I didn't get any objection
> from others (including Linus) for about 2 months. That isn't because
> of someone likes it, rather we cannot make no progress compared with
> some exist fs community because this is our love work.
>
> And it's self-contained driver at least, and it's disabled by default,
> It cannot be stayed in staging tree to do a lot of EROFS feature
> improvements itself forever (since it is cleaned enough).
> It has proven its validity as well.
It seems I misunderstood your idea, sorry about that... EROFS
properly uses vfs interfaces (e.g. we also considered RCU symlink
lookup path at the very beginning of our design as Al said [1],
except for mount interface as Al mentioned [2] (thanks him for
taking some time on it), it was used for our debugging use),
and it didn't cause any extra burden to vfs or other subsystems.
[1] https://lore.kernel.org/r/20190325045744.GK2217@ZenIV.linux.org.uk/
[2] https://lore.kernel.org/r/20190720224955.GD17978@ZenIV.linux.org.uk/
Thanks,
Gao Xiang
>
> Thanks,
> Gao Xiang
>
next prev parent reply other threads:[~2019-08-29 8:25 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 16:08 [PATCH] staging: exfat: add exfat filesystem code to staging Greg Kroah-Hartman
2019-08-28 17:00 ` Greg Kroah-Hartman
2019-08-29 6:23 ` Christoph Hellwig
2019-08-29 6:39 ` Greg Kroah-Hartman
2019-08-29 9:41 ` Christoph Hellwig
2019-08-29 9:50 ` Greg Kroah-Hartman
2019-08-29 10:37 ` Christoph Hellwig
2019-08-29 11:04 ` Gao Xiang
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 15:11 ` Dan Carpenter
2019-08-29 15:27 ` Gao Xiang
2019-08-29 15:43 ` Dan Carpenter
2019-08-29 15:51 ` Gao Xiang
2019-08-29 16:04 ` Gao Xiang
2019-08-30 8:34 ` Dan Carpenter
2019-08-30 8:43 ` Gao Xiang
2019-08-30 11:26 ` Dan Carpenter
2019-08-30 12:04 ` Gao Xiang
2019-08-29 16:44 ` Gao Xiang
2019-08-29 16:59 ` Joe Perches
2019-08-29 17:02 ` Gao Xiang
2019-08-30 2:06 ` Chao Yu
2019-08-30 6:38 ` Gao Xiang
2019-08-30 12:00 ` Checking usage of likeliness annotations Markus Elfring
2019-08-30 12:00 ` Markus Elfring
2019-08-30 11:51 ` [PATCH] staging: exfat: add exfat filesystem code to staging David Sterba
2019-08-31 3:50 ` Chao Yu
2019-08-30 15:36 ` Christoph Hellwig
2019-08-30 21:54 ` Dave Chinner
2019-08-31 10:31 ` Valdis Klētnieks
2019-09-01 0:04 ` Dave Chinner
2019-08-29 7:01 ` Gao Xiang
2019-08-29 8:24 ` Gao Xiang [this message]
2019-08-29 9:51 ` Christoph Hellwig
2019-08-29 12:14 ` Pali Rohár
2019-08-29 12:34 ` Valdis Klētnieks
2019-08-29 12:46 ` Pali Rohár
2019-08-29 14:08 ` Markus Elfring
2019-08-29 14:08 ` Markus Elfring
2019-08-29 15:44 ` Markus Elfring
2019-08-29 15:44 ` Markus Elfring
2019-08-29 20:56 ` Pali Rohár
2019-08-29 23:18 ` Valdis Klētnieks
2019-08-29 23:35 ` Sasha Levin
2019-08-30 7:56 ` Pali Rohár
2019-10-16 14:03 ` Pali Rohár
2019-10-16 14:31 ` Sasha Levin
2019-10-16 16:03 ` Pali Rohár
2019-10-16 16:20 ` Sasha Levin
2019-10-16 16:22 ` Greg Kroah-Hartman
2019-10-16 16:32 ` Pali Rohár
2019-10-16 16:50 ` Greg Kroah-Hartman
2019-10-16 20:33 ` Sasha Levin
2019-10-16 21:53 ` Valdis Klētnieks
2019-10-17 7:53 ` Pali Rohár
2019-10-17 7:50 ` Pali Rohár
2020-02-13 0:06 ` Pali Rohár
2020-02-13 21:18 ` Sasha Levin
2020-02-14 22:16 ` Valdis Klētnieks
2020-02-14 22:43 ` Pali Rohár
2020-02-14 23:25 ` Valdis Klētnieks
2020-04-21 21:30 ` exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging) Pali Rohár
2020-04-27 15:49 ` Sasha Levin
2020-04-28 7:46 ` Pali Rohár
2019-10-16 16:05 ` [PATCH] staging: exfat: add exfat filesystem code to staging Valdis Klētnieks
2019-08-30 8:03 ` Pali Rohár
2019-08-30 15:40 ` Christoph Hellwig
2019-08-30 15:43 ` Pali Rohár
2019-09-14 13:39 ` [PATCH] staging: exfat: add exfat filesystem code to Park Ju Hyung
2019-09-15 13:54 ` Greg KH
2019-09-15 16:11 ` Ju Hyung Park
[not found] ` <20190918195920.25210-1-qkrwngud825@gmail.com>
2019-09-18 20:12 ` [PATCH] staging: exfat: rebase to sdFAT v2.2.0 Greg KH
2019-09-18 20:13 ` Greg KH
2019-09-18 20:22 ` Ju Hyung Park
2019-09-18 20:26 ` Greg KH
2019-09-18 20:31 ` Ju Hyung Park
2019-09-18 20:46 ` Valdis Klētnieks
2019-09-18 21:31 ` kbuild test robot
2019-09-18 22:17 ` Ju Hyung Park
2019-09-18 21:31 ` kbuild test robot
2019-10-24 9:39 ` [PATCH] staging: exfat: add exfat filesystem code to staging Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829082409.GA83154@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=alexander.levin@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=miaoxie@huawei.com \
--cc=tytso@mit.edu \
--cc=valdis.kletnieks@vt.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.