From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: "François Valenduc" <francoisvalenduc@gmail.com>,
stable@vger.kernel.org, henryburns@google.com,
sergey.senozhatsky@gmail.com,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: Kernel 5.2.11 dpes not compile
Date: Thu, 29 Aug 2019 21:32:57 +0900 [thread overview]
Message-ID: <20190829123257.GA8726@jagdpanzerIV> (raw)
In-Reply-To: <015acb3e-6722-70c8-b0d5-822f1505fed2@suse.cz>
On (08/29/19 14:28), Jiri Slaby wrote:
[..]
> as is its definition in the structure (and its other uses).
>
> > ./include/linux/wait.h:67:26: note: in definition of macro ‘init_waitqueue_head’
> > __init_waitqueue_head((wq_head), #wq_head, &__key); \
> > ^~~~~~~
> > scripts/Makefile.build:278: recipe for target 'mm/zsmalloc.o' failed
> > make[1]: *** [mm/zsmalloc.o] Error 1
> > Makefile:1073: recipe for target 'mm' failed
> >
> > You can find my configuration file attached.
>
> You forgot to attach it, but you have CONFIG_COMPACTION=n, I assume.
>
> > Does anybody have any idea about this ?
>
> Sure, this will fix it (or turn on compaction):
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2413,7 +2413,9 @@ struct zs_pool *zs_create_pool(const char *name)
> if (!pool->name)
> goto err;
>
> +#ifdef CONFIG_COMPACTION
> init_waitqueue_head(&pool->migration_wait);
> +#endif
The fix is correct. I believe Andrew already has the same patch
in his tree.
-ss
next prev parent reply other threads:[~2019-08-29 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 12:13 Kernel 5.2.11 dpes not compile François Valenduc
2019-08-29 12:28 ` Jiri Slaby
2019-08-29 12:31 ` François Valenduc
2019-08-29 12:32 ` Sergey Senozhatsky [this message]
2019-09-02 18:01 ` François Valenduc
2019-09-02 18:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829123257.GA8726@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=francoisvalenduc@gmail.com \
--cc=henryburns@google.com \
--cc=jslaby@suse.cz \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.