From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines
Date: Thu, 29 Aug 2019 09:29:49 -0400 [thread overview]
Message-ID: <20190829132949.GA6744@redhat.com> (raw)
In-Reply-To: <CAJfpegv_XS=kLxw_FzWNM2Xao5wsn7oGbk3ow78gU8tpXwo-sg@mail.gmail.com>
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote:
> On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > Hi,
> >
> > Here are the V3 patches for virtio-fs filesystem. This time I have
> > broken the patch series in two parts. This is first part which does
> > not contain DAX support. Second patch series will contain the patches
> > for DAX support.
> >
> > I have also dropped RFC tag from first patch series as we believe its
> > in good enough shape that it should get a consideration for inclusion
> > upstream.
>
> Pushed out to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next
>
Hi Miklos,
Compilation of virtio-fs as module fails. While it works if compiled as
non-module.
fs/fuse/virtio_fs.c: In function ‘copy_args_to_argbuf’:
fs/fuse/virtio_fs.c:255:5: error: ‘struct fuse_req’ has no member named ‘argbuf’
req->argbuf = kmalloc(len, GFP_ATOMIC);
It can't find req->argbuf.
I noticed that you have put ifdef around argbuf.
#ifdef CONFIG_VIRTIO_FS
/** virtio-fs's physically contiguous buffer for in and out args */
void *argbuf;
#endif
It should have worked. Not sure why it is not working.
Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines
Date: Thu, 29 Aug 2019 09:29:49 -0400 [thread overview]
Message-ID: <20190829132949.GA6744@redhat.com> (raw)
In-Reply-To: <CAJfpegv_XS=kLxw_FzWNM2Xao5wsn7oGbk3ow78gU8tpXwo-sg@mail.gmail.com>
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote:
> On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > Hi,
> >
> > Here are the V3 patches for virtio-fs filesystem. This time I have
> > broken the patch series in two parts. This is first part which does
> > not contain DAX support. Second patch series will contain the patches
> > for DAX support.
> >
> > I have also dropped RFC tag from first patch series as we believe its
> > in good enough shape that it should get a consideration for inclusion
> > upstream.
>
> Pushed out to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next
>
Hi Miklos,
Compilation of virtio-fs as module fails. While it works if compiled as
non-module.
fs/fuse/virtio_fs.c: In function ‘copy_args_to_argbuf’:
fs/fuse/virtio_fs.c:255:5: error: ‘struct fuse_req’ has no member named ‘argbuf’
req->argbuf = kmalloc(len, GFP_ATOMIC);
It can't find req->argbuf.
I noticed that you have put ifdef around argbuf.
#ifdef CONFIG_VIRTIO_FS
/** virtio-fs's physically contiguous buffer for in and out args */
void *argbuf;
#endif
It should have worked. Not sure why it is not working.
Vivek
next prev parent reply other threads:[~2019-08-29 13:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 17:37 [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 01/13] fuse: delete dentry if timeout is zero Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 02/13] fuse: Use default_file_splice_read for direct IO Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-28 7:45 ` [Virtio-fs] " Miklos Szeredi
2019-08-28 7:45 ` Miklos Szeredi
2019-08-28 12:27 ` [Virtio-fs] " Vivek Goyal
2019-08-28 12:27 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 03/13] fuse: export fuse_end_request() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 04/13] fuse: export fuse_len_args() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 05/13] fuse: Export fuse_send_init_request() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 06/13] fuse: export fuse_get_unique() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 07/13] Export fuse_dequeue_forget() function Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 08/13] fuse: extract fuse_fill_super_common() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 09/13] fuse: add fuse_iqueue_ops callbacks Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 10/13] fuse: Separate fuse device allocation and installation in fuse_conn Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 11/13] virtio_fs: add skeleton virtio_fs.ko module Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 12/13] virtio-fs: Do not provide abort interface in fusectl Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 13/13] init/do_mounts.c: add virtio_fs root fs support Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-29 9:28 ` [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines Miklos Szeredi
2019-08-29 9:28 ` Miklos Szeredi
2019-08-29 11:58 ` [Virtio-fs] " Vivek Goyal
2019-08-29 11:58 ` Vivek Goyal
2019-08-29 12:35 ` [Virtio-fs] " Stefan Hajnoczi
2019-08-29 12:35 ` Stefan Hajnoczi
2019-08-29 13:29 ` Vivek Goyal [this message]
2019-08-29 13:29 ` Vivek Goyal
2019-08-29 13:41 ` [Virtio-fs] " Miklos Szeredi
2019-08-29 13:41 ` Miklos Szeredi
2019-08-29 14:31 ` [Virtio-fs] " Vivek Goyal
2019-08-29 14:31 ` Vivek Goyal
2019-08-29 14:47 ` [Virtio-fs] " Miklos Szeredi
2019-08-29 14:47 ` Miklos Szeredi
2019-08-29 16:01 ` [Virtio-fs] " Vivek Goyal
2019-08-29 16:01 ` Vivek Goyal
2019-08-31 5:46 ` [Virtio-fs] " Miklos Szeredi
2019-08-31 5:46 ` Miklos Szeredi
2019-09-03 8:05 ` [Virtio-fs] " Miklos Szeredi
2019-09-03 8:05 ` Miklos Szeredi
2019-09-03 8:31 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 8:31 ` Michael S. Tsirkin
2019-09-03 9:17 ` [Virtio-fs] " Miklos Szeredi
2019-09-03 9:17 ` Miklos Szeredi
2019-09-04 15:54 ` Stefan Hajnoczi
2019-09-04 15:54 ` [Virtio-fs] " Stefan Hajnoczi
2019-09-04 15:54 ` Stefan Hajnoczi
2019-09-03 14:07 ` Vivek Goyal
2019-09-03 14:07 ` [Virtio-fs] " Vivek Goyal
2019-09-03 14:07 ` Vivek Goyal
2019-09-03 14:12 ` Michael S. Tsirkin
2019-09-03 14:12 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 14:12 ` Michael S. Tsirkin
2019-09-03 14:18 ` [Virtio-fs] " Vivek Goyal
2019-09-03 14:18 ` Vivek Goyal
2019-09-03 17:15 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 17:15 ` Michael S. Tsirkin
2019-09-03 17:15 ` Michael S. Tsirkin
2019-09-03 14:18 ` Vivek Goyal
2019-09-03 8:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829132949.GA6744@redhat.com \
--to=vgoyal@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.