From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE142C3A59F for ; Thu, 29 Aug 2019 16:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAF1C2189D for ; Thu, 29 Aug 2019 16:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbfH2Quy (ORCPT ); Thu, 29 Aug 2019 12:50:54 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38855 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2Qux (ORCPT ); Thu, 29 Aug 2019 12:50:53 -0400 Received: by mail-wm1-f67.google.com with SMTP id o184so4553699wme.3; Thu, 29 Aug 2019 09:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EAPNXwtNcvomkAv43HK7BcSQSi3ID9bH+hr63tWVdSI=; b=B5HGm8Y0d+BC3TOmZ23uuf+WqGqYOV7ombVlzG70cKlsV5JRtEvvNhzfPX4mECWFhx u5j/9cXAx5IqdKYxp7N//EOr02YdCxMO9TImOTBYGSfNXGWuDvoj6pJX11SgB//Tt5im yYal4ni8RQu92gT5EGlqUSz2C0ZgmGFTTf+a6stQq6hqSBqIOsB4/FaV7WQu1kPe6C3X +xLocX36sKRkLLs3x2PB2D+myD7iamK/wRKiMKBKp2+VCm7/qCDUbUDyTARThORMu67E QuOMPvFXZtlfAMMmQxgNFbLz16ewEqahiYYT8vzew1IHcjJ1Y165M5UTbENb5n3dJ24k kxqA== X-Gm-Message-State: APjAAAX+kGHw6qYwNcIPCIAbgM17lyiHVPh/qD8mC15U8cFFX3Ij61QJ D4+f5ZSeYUoFEP3fmz575wgwXYvwuHo= X-Google-Smtp-Source: APXvYqyG8Uv9qqAEzfuwRYVShx38vJV1pUSPq3W7ZBAlPx5+N1oEiU4zijmswr1WDwZJj2S7mhEW8w== X-Received: by 2002:a1c:f704:: with SMTP id v4mr361727wmh.90.1567097450438; Thu, 29 Aug 2019 09:50:50 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:50:49 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Cc: Denis Efremov , Alexander Viro , Anton Altaparmakov , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , Inaky Perez-Gonzalez , Juergen Gross , Leon Romanovsky , Mike Marciniszyn , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Rob Clark , Saeed Mahameed , Sean Paul , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com, linux-xfs@vger.kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Joe Perches , Andrew Morton , Andy Whitcroft Subject: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Date: Thu, 29 Aug 2019 19:50:15 +0300 Message-Id: <20190829165025.15750-1-efremov@linux.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org IS_ERR(), IS_ERR_OR_NULL(), IS_ERR_VALUE() and WARN*() already contain unlikely() optimization internally. Thus, there is no point in calling these functions and defines under likely()/unlikely(). This check is based on the coccinelle rule developed by Enrico Weigelt https://lore.kernel.org/lkml/1559767582-11081-1-git-send-email-info@metux.net/ Signed-off-by: Denis Efremov Cc: Joe Perches Cc: Andrew Morton Cc: Andy Whitcroft --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..56969ce06df4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6480,6 +6480,12 @@ sub process { "Using $1 should generally have parentheses around the comparison\n" . $herecurr); } +# nested likely/unlikely calls + if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { + WARN("LIKELY_MISUSE", + "nested (un)?likely() calls, $1 already uses unlikely() internally\n" . $herecurr); + } + # whine mightly about in_atomic if ($line =~ /\bin_atomic\s*\(/) { if ($realfile =~ m@^drivers/@) { -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Efremov Subject: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Date: Thu, 29 Aug 2019 19:50:15 +0300 Message-ID: <20190829165025.15750-1-efremov@linux.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Denis Efremov , Alexander Viro , Anton Altaparmakov , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , Inaky Perez-Gonzalez , Juergen Gross , Leon Romanovsky , Mike Marciniszyn , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Rob Clark , Saeed Mahameed , Sean Paul , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kern List-Id: linux-input@vger.kernel.org IS_ERR(), IS_ERR_OR_NULL(), IS_ERR_VALUE() and WARN*() already contain unlikely() optimization internally. Thus, there is no point in calling these functions and defines under likely()/unlikely(). This check is based on the coccinelle rule developed by Enrico Weigelt https://lore.kernel.org/lkml/1559767582-11081-1-git-send-email-info@metux.net/ Signed-off-by: Denis Efremov Cc: Joe Perches Cc: Andrew Morton Cc: Andy Whitcroft --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..56969ce06df4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6480,6 +6480,12 @@ sub process { "Using $1 should generally have parentheses around the comparison\n" . $herecurr); } +# nested likely/unlikely calls + if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { + WARN("LIKELY_MISUSE", + "nested (un)?likely() calls, $1 already uses unlikely() internally\n" . $herecurr); + } + # whine mightly about in_atomic if ($line =~ /\bin_atomic\s*\(/) { if ($realfile =~ m@^drivers/@) { -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B296FC3A5A6 for ; Thu, 29 Aug 2019 17:39:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 918922189D for ; Thu, 29 Aug 2019 17:39:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 918922189D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i3OOB-0001Yh-Uj; Thu, 29 Aug 2019 17:39:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i3NdM-0006hu-Tc for xen-devel@lists.xenproject.org; Thu, 29 Aug 2019 16:50:52 +0000 X-Inumbo-ID: 28595dca-ca7d-11e9-b95f-bc764e2007e4 Received: from mail-wm1-f66.google.com (unknown [209.85.128.66]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28595dca-ca7d-11e9-b95f-bc764e2007e4; Thu, 29 Aug 2019 16:50:51 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id g207so480848wmg.5 for ; Thu, 29 Aug 2019 09:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EAPNXwtNcvomkAv43HK7BcSQSi3ID9bH+hr63tWVdSI=; b=TGytwZQV1DIJBWP5nSctRyZeHLxD715P1rKU+KdemBchsazJ4qyLfGwYuZUu8H7HyH ASplT4CzQvQG7zxaxCF31kV5J3jxu2a2VtSipf4YUI8zFsy4DxfDGeJKLy/JJpIiy3v8 6tW1FSiw1pXchBQLSo2rIBKpazt0a4mOddBXfRWRi9fkpoLEjyRd0qtj3nbTE3xFWJBJ SLDKY3ii/Ofi+elnCo8+NN65v7SHhSMiMEGGp8Qb0xY/CYhYrz+RuOmt5lRUiAeSYUas Ak5kyvAhaV5eT8sRRVUECndkgucnpxExlSd2TQReVLSz3Qlv/EOCAACCps4qBFROIMcy lGRw== X-Gm-Message-State: APjAAAXMov5mTmoyppMVc/dwEbgnUHI0WPivBSyORCbIcFn6wBvoTpZa mHvNZfkprlzcv24dkTe/Ydo= X-Google-Smtp-Source: APXvYqyG8Uv9qqAEzfuwRYVShx38vJV1pUSPq3W7ZBAlPx5+N1oEiU4zijmswr1WDwZJj2S7mhEW8w== X-Received: by 2002:a1c:f704:: with SMTP id v4mr361727wmh.90.1567097450438; Thu, 29 Aug 2019 09:50:50 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:50:49 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Date: Thu, 29 Aug 2019 19:50:15 +0300 Message-Id: <20190829165025.15750-1-efremov@linux.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 29 Aug 2019 17:39:14 +0000 Subject: [Xen-devel] [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Leon Romanovsky , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Inaky Perez-Gonzalez , Saeed Mahameed , linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Pismenny , linux-arm-msm@vger.kernel.org, Denis Efremov , linux-wimax@intel.com, Joe Perches , Alexander Viro , Andy Whitcroft , Boris Ostrovsky , Sean Paul , Anton Altaparmakov , Juergen Gross , Mike Marciniszyn , linux-ntfs-dev@lists.sourceforge.net, netdev@vger.kernel.org, Dennis Dalessandro , Dmitry Torokhov , linux-xfs@vger.kernel.org, Rob Clark , =?UTF-8?q?Pali=20Roh=C3=A1r?= , linux-fsdevel@vger.kernel.org, Andrew Morton , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" SVNfRVJSKCksIElTX0VSUl9PUl9OVUxMKCksIElTX0VSUl9WQUxVRSgpIGFuZCBXQVJOKigpIGFs cmVhZHkgY29udGFpbgp1bmxpa2VseSgpIG9wdGltaXphdGlvbiBpbnRlcm5hbGx5LiBUaHVzLCB0 aGVyZSBpcyBubyBwb2ludCBpbiBjYWxsaW5nCnRoZXNlIGZ1bmN0aW9ucyBhbmQgZGVmaW5lcyB1 bmRlciBsaWtlbHkoKS91bmxpa2VseSgpLgoKVGhpcyBjaGVjayBpcyBiYXNlZCBvbiB0aGUgY29j Y2luZWxsZSBydWxlIGRldmVsb3BlZCBieSBFbnJpY28gV2VpZ2VsdApodHRwczovL2xvcmUua2Vy bmVsLm9yZy9sa21sLzE1NTk3Njc1ODItMTEwODEtMS1naXQtc2VuZC1lbWFpbC1pbmZvQG1ldHV4 Lm5ldC8KClNpZ25lZC1vZmYtYnk6IERlbmlzIEVmcmVtb3YgPGVmcmVtb3ZAbGludXguY29tPgpD YzogSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4KQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1A bGludXgtZm91bmRhdGlvbi5vcmc+CkNjOiBBbmR5IFdoaXRjcm9mdCA8YXB3QGNhbm9uaWNhbC5j b20+Ci0tLQogc2NyaXB0cy9jaGVja3BhdGNoLnBsIHwgNiArKysrKysKIDEgZmlsZSBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zY3JpcHRzL2NoZWNrcGF0Y2gucGwgYi9z Y3JpcHRzL2NoZWNrcGF0Y2gucGwKaW5kZXggOTNhN2VkZmUwZjA1Li41Njk2OWNlMDZkZjQgMTAw NzU1Ci0tLSBhL3NjcmlwdHMvY2hlY2twYXRjaC5wbAorKysgYi9zY3JpcHRzL2NoZWNrcGF0Y2gu cGwKQEAgLTY0ODAsNiArNjQ4MCwxMiBAQCBzdWIgcHJvY2VzcyB7CiAJCQkgICAgICJVc2luZyAk MSBzaG91bGQgZ2VuZXJhbGx5IGhhdmUgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSBjb21wYXJpc29u XG4iIC4gJGhlcmVjdXJyKTsKIAkJfQogCisjIG5lc3RlZCBsaWtlbHkvdW5saWtlbHkgY2FsbHMK KwkJaWYgKCRsaW5lID1+IC9cYig/Oig/OnVuKT9saWtlbHkpXHMqXChccyohP1xzKihJU19FUlIo PzpfT1JfTlVMTHxfVkFMVUUpP3xXQVJOKS8pIHsKKwkJCVdBUk4oIkxJS0VMWV9NSVNVU0UiLAor CQkJICAgICAibmVzdGVkICh1bik/bGlrZWx5KCkgY2FsbHMsICQxIGFscmVhZHkgdXNlcyB1bmxp a2VseSgpIGludGVybmFsbHlcbiIgLiAkaGVyZWN1cnIpOworCQl9CisKICMgd2hpbmUgbWlnaHRs eSBhYm91dCBpbl9hdG9taWMKIAkJaWYgKCRsaW5lID1+IC9cYmluX2F0b21pY1xzKlwoLykgewog CQkJaWYgKCRyZWFsZmlsZSA9fiBtQF5kcml2ZXJzL0ApIHsKLS0gCjIuMjEuMAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=