From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAE3C3A59F for ; Thu, 29 Aug 2019 17:39:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CDBF21726 for ; Thu, 29 Aug 2019 17:39:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CDBF21726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i3OOC-0001Yn-7Q; Thu, 29 Aug 2019 17:39:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i3Ndr-0006jA-1Y for xen-devel@lists.xenproject.org; Thu, 29 Aug 2019 16:51:23 +0000 X-Inumbo-ID: 3abf79a4-ca7d-11e9-ae71-12813bfff9fa Received: from mail-wm1-f68.google.com (unknown [209.85.128.68]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3abf79a4-ca7d-11e9-ae71-12813bfff9fa; Thu, 29 Aug 2019 16:51:22 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id d16so4551369wme.2 for ; Thu, 29 Aug 2019 09:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YWO650+kQjgd0freSzG4GVYInuwUakQ2FRAAY/0z/rI=; b=TqnKbVJQNPkbmqyIgYF3tHv/dzOrxHPS8KlZ9sikmlCojkABPl6YjDXFrsKkLJzgXS PvCks7N2UcPUJ7YSA9LYQQbNBSn0oVp+MKO92WPMtKMC2dqRlaBljYoyQGRMfyv7Y9dx oYibrl2jXDH/tSEYunIdjTINPcELNpXsLVg6X061L6/ZRSsbkAaHhpXdeUnihGLE+zCZ TT056vFarqOYDTuTuF0aC7jnaHsD63KVP59ZVjnV7pkjvRmke/HQOMGQEuND4XGKnu0K yHNUnW+PuzIGJ8+1GRTHIryEaY4/XDCDE1MmMxoRQOeQKMHvXFUubhOBwRn7ZrZhJEPi MGcQ== X-Gm-Message-State: APjAAAXcs1RZ6AbZQ7AlBv077o4AknVuGhLLcAH3zlGYxv7zOCz9BZCv qDkCWVl1DSBinrMxDCnwFaQ= X-Google-Smtp-Source: APXvYqzoDiooG1fxgtlB90KCm2/ikDEZkuoKce/dvTUg9dkOr5UrMz18qNY8RMFolm7jcxa9qIDUiQ== X-Received: by 2002:a7b:c195:: with SMTP id y21mr12562563wmi.16.1567097481381; Thu, 29 Aug 2019 09:51:21 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:51:21 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Date: Thu, 29 Aug 2019 19:50:18 +0300 Message-Id: <20190829165025.15750-4-efremov@linux.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190829165025.15750-1-efremov@linux.com> References: <20190829165025.15750-1-efremov@linux.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 29 Aug 2019 17:39:14 +0000 Subject: [Xen-devel] [PATCH v3 04/11] xen/events: Remove unlikely() from WARN() condition X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Denis Efremov , Joe Perches , xen-devel@lists.xenproject.org, Boris Ostrovsky , Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" InVubGlrZWx5KFdBUk4oeCkpIiBpcyBleGNlc3NpdmUuIFdBUk4oKSBhbHJlYWR5IHVzZXMgdW5s aWtlbHkoKQppbnRlcm5hbGx5LgoKU2lnbmVkLW9mZi1ieTogRGVuaXMgRWZyZW1vdiA8ZWZyZW1v dkBsaW51eC5jb20+CkNjOiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUu Y29tPgpDYzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpDYzogSm9lIFBlcmNoZXMg PGpvZUBwZXJjaGVzLmNvbT4KQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlv bi5vcmc+CkNjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKLS0tCiBkcml2ZXJzL3hl bi9ldmVudHMvZXZlbnRzX2Jhc2UuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVu dHNfYmFzZS5jIGIvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMKaW5kZXggMmU4NTcw YzA5Nzg5Li42Yzg4NDM5NjhhNTIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVu dHNfYmFzZS5jCisrKyBiL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jCkBAIC0yNDcs NyArMjQ3LDcgQEAgc3RhdGljIHZvaWQgeGVuX2lycV9pbmZvX2NsZWFudXAoc3RydWN0IGlycV9p bmZvICppbmZvKQogICovCiB1bnNpZ25lZCBpbnQgZXZ0Y2huX2Zyb21faXJxKHVuc2lnbmVkIGly cSkKIHsKLQlpZiAodW5saWtlbHkoV0FSTihpcnEgPj0gbnJfaXJxcywgIkludmFsaWQgaXJxICVk IVxuIiwgaXJxKSkpCisJaWYgKFdBUk4oaXJxID49IG5yX2lycXMsICJJbnZhbGlkIGlycSAlZCFc biIsIGlycSkpCiAJCXJldHVybiAwOwogCiAJcmV0dXJuIGluZm9fZm9yX2lycShpcnEpLT5ldnRj aG47Ci0tIAoyLjIxLjAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01488C3A59F for ; Thu, 29 Aug 2019 16:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE89B233FF for ; Thu, 29 Aug 2019 16:51:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfH2QvZ (ORCPT ); Thu, 29 Aug 2019 12:51:25 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54898 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2QvX (ORCPT ); Thu, 29 Aug 2019 12:51:23 -0400 Received: by mail-wm1-f65.google.com with SMTP id k2so3018176wmj.4 for ; Thu, 29 Aug 2019 09:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YWO650+kQjgd0freSzG4GVYInuwUakQ2FRAAY/0z/rI=; b=pFfR6QaFX/f5q+PRifIkEFLx76QPxvpS/Z0z/GSPLwy9vWF6qL0hqJvJHnBEbs6qiV m1V7nm7/bt2zoShZgPjtFkblDCAs0VncBGRNNuSHxlp4e7akEUd4FDNbR1ASoQ+vuMkM L7oaa/XtglHdkwWLWBftCFkzFIBFDxZgIx1kTcWa/+z1jfXYwlkBI+283iivfFCCazoN O3HY8nfakmUh1IXzuMOzUOsPzKMqmUryqwm4XR9+HM+/4YRNZWA2K8uZq0JGyo/RKqFg LdEg9waAxjD5FZAmasYMe7nxEoCpZWq7svt/yp1cF7A+Pa6Wgf1zWxivJ3Dm4ET/F1fl UulA== X-Gm-Message-State: APjAAAW7iU9voUVyoj6BHD6Q98vVSdWyWvpkUGwUfGUXfg/24W5PJjtn Dis1cqHULyF7Xli5p35plRvrX1s+B88= X-Google-Smtp-Source: APXvYqzoDiooG1fxgtlB90KCm2/ikDEZkuoKce/dvTUg9dkOr5UrMz18qNY8RMFolm7jcxa9qIDUiQ== X-Received: by 2002:a7b:c195:: with SMTP id y21mr12562563wmi.16.1567097481381; Thu, 29 Aug 2019 09:51:21 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:51:21 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Cc: Denis Efremov , Boris Ostrovsky , Juergen Gross , Joe Perches , Andrew Morton , xen-devel@lists.xenproject.org Subject: [PATCH v3 04/11] xen/events: Remove unlikely() from WARN() condition Date: Thu, 29 Aug 2019 19:50:18 +0300 Message-Id: <20190829165025.15750-4-efremov@linux.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190829165025.15750-1-efremov@linux.com> References: <20190829165025.15750-1-efremov@linux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "unlikely(WARN(x))" is excessive. WARN() already uses unlikely() internally. Signed-off-by: Denis Efremov Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Joe Perches Cc: Andrew Morton Cc: xen-devel@lists.xenproject.org --- drivers/xen/events/events_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 2e8570c09789..6c8843968a52 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -247,7 +247,7 @@ static void xen_irq_info_cleanup(struct irq_info *info) */ unsigned int evtchn_from_irq(unsigned irq) { - if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq))) + if (WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)) return 0; return info_for_irq(irq)->evtchn; -- 2.21.0