From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH v2 2/2] drm/i915/display: Move the
 commit_tail() disable sequence to separate function
Date: Thu, 29 Aug 2019 14:18:14 -0700
Message-ID: <20190829211814.GK701@intel.com>
References: <20190827221735.29351-3-manasi.d.navare@intel.com>
 <20190828224701.422-1-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id F24376E219
 for <intel-gfx@lists.freedesktop.org>; Thu, 29 Aug 2019 21:16:34 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190828224701.422-1-manasi.d.navare@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

VGhhbmtzIGZvciB0aGUgcmV2aWV3IHB1c2hlZCB0byBkaW5xCgpNYW5hc2kKCk9uIFdlZCwgQXVn
IDI4LCAyMDE5IGF0IDAzOjQ3OjAxUE0gLTA3MDAsIE1hbmFzaSBOYXZhcmUgd3JvdGU6Cj4gQ3Jl
YXRlIGEgbmV3IGZ1bmN0aW9uIGludGVsX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKCkgY29uc2lz
dGVudCB3aXRoIHRoZSBuYW1pbmcKPiBpbiBkcm0gYXRvbWljIGhlbHBlcnMgYW5kIHNpbWlsYXIg
dG8gdGhlIGVuYWJsZSBmdW5jdGlvbi4KPiBUaGlzIGhlbHBzIGJldHRlciBvcmdhbml6ZSB0aGUg
ZGlzYWJsZSBzZXF1ZW5jZSBpbiBhdG9taWNfY29tbWl0X3RhaWwoKQo+IAo+IE5vIGZ1bmN0aW9u
YWwgY2hhbmdlCj4gCj4gdjQ6Cj4gKiBEbyBub3QgY3JlYXRlIGEgZnVuY3Rpb24gcG9pbnRlciwg
anVzdCBhIGZ1bmN0aW9uIChNYWFydGVuKQo+IHYzOgo+ICogUmViYXNlIChNYW5hc2kpCj4gdjI6
Cj4gKiBDcmVhdGUgYSBoZWxwZXIgZm9yIG9sZF9jcnRjX3N0YXRlIGRpc2FibGVzIChMdWNhcykK
PiAKPiBTdWdnZXN0ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29t
Pgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+
IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29t
Pgo+IENjOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IENjOiBKYW5p
IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hbmFzaSBO
YXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIHwgOTIgKysrKysrKysrKysrLS0tLS0tLS0K
PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICAgICAgfCAgMSArCj4g
IDIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4gCj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA3
N2RmYjBmNmE2ZTAuLjVjNTNiNDVkYzA2ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEzNzU4LDYgKzEzNzU4LDYxIEBAIHN0YXRp
YyB2b2lkIGludGVsX3VwZGF0ZV9jcnRjKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJaW50
ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0YXRlLCBjcnRjKTsKPiAgfQo+ICAKPiArc3RhdGljIHZv
aWQgaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoc3RydWN0IGludGVsX2F0b21pY19zdGF0
ZSAqc3RhdGUsCj4gKwkJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3Rh
dGUsCj4gKwkJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUsCj4g
KwkJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShzdGF0ZS0+YmFzZS5kZXYpOwo+ICsKPiArCWlu
dGVsX2NydGNfZGlzYWJsZV9wbGFuZXMoc3RhdGUsIGNydGMpOwo+ICsKPiArCS8qCj4gKwkgKiBX
ZSBuZWVkIHRvIGRpc2FibGUgcGlwZSBDUkMgYmVmb3JlIGRpc2FibGluZyB0aGUgcGlwZSwKPiAr
CSAqIG9yIHdlIHJhY2UgYWdhaW5zdCB2Ymxhbmsgb2ZmLgo+ICsJICovCj4gKwlpbnRlbF9jcnRj
X2Rpc2FibGVfcGlwZV9jcmMoY3J0Yyk7Cj4gKwo+ICsJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19k
aXNhYmxlKG9sZF9jcnRjX3N0YXRlLCBzdGF0ZSk7Cj4gKwljcnRjLT5hY3RpdmUgPSBmYWxzZTsK
PiArCWludGVsX2ZiY19kaXNhYmxlKGNydGMpOwo+ICsJaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBs
bChvbGRfY3J0Y19zdGF0ZSk7Cj4gKwo+ICsJLyoKPiArCSAqIFVuZGVycnVucyBkb24ndCBhbHdh
eXMgcmFpc2UgaW50ZXJydXB0cywKPiArCSAqIHNvIGNoZWNrIG1hbnVhbGx5Lgo+ICsJICovCj4g
KwlpbnRlbF9jaGVja19jcHVfZmlmb191bmRlcnJ1bnMoZGV2X3ByaXYpOwo+ICsJaW50ZWxfY2hl
Y2tfcGNoX2ZpZm9fdW5kZXJydW5zKGRldl9wcml2KTsKPiArCj4gKwkvKiBGSVhNRSB1bmlmeSB0
aGlzIGZvciBhbGwgcGxhdGZvcm1zICovCj4gKwlpZiAoIW5ld19jcnRjX3N0YXRlLT5iYXNlLmFj
dGl2ZSAmJgo+ICsJICAgICFIQVNfR01DSChkZXZfcHJpdikgJiYKPiArCSAgICBkZXZfcHJpdi0+
ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuaW5pdGlh
bF93YXRlcm1hcmtzKHN0YXRlLAo+ICsJCQkJCQkgICAgIG5ld19jcnRjX3N0YXRlKTsKPiArfQo+
ICsKPiArc3RhdGljIHZvaWQgaW50ZWxfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMoc3RydWN0IGlu
dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl
ICpuZXdfY3J0Y19zdGF0ZSwgKm9sZF9jcnRjX3N0YXRlOwo+ICsJc3RydWN0IGludGVsX2NydGMg
KmNydGM7Cj4gKwlpbnQgaTsKPiArCj4gKwlmb3JfZWFjaF9vbGRuZXdfaW50ZWxfY3J0Y19pbl9z
dGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4g
KwkJaWYgKCFuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiArCQkJY29udGludWU7Cj4g
Kwo+ICsJCWludGVsX3ByZV9wbGFuZV91cGRhdGUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0
YXRlKTsKPiArCj4gKwkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkKPiArCQkJaW50
ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoc3RhdGUsCj4gKwkJCQkJCSAgICAgIG9sZF9jcnRj
X3N0YXRlLAo+ICsJCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0ZSwKPiArCQkJCQkJICAgICAgY3J0
Yyk7Cj4gKwl9Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGludGVsX2NvbW1pdF9tb2Rlc2V0X2Vu
YWJsZXMoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBp
bnRlbF9jcnRjICpjcnRjOwo+IEBAIC0xMzkzOCw0MiArMTM5OTMsMTAgQEAgc3RhdGljIHZvaWQg
aW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRl
KQo+ICAJCQlwdXRfZG9tYWluc1tjcnRjLT5waXBlXSA9Cj4gIAkJCQltb2Rlc2V0X2dldF9jcnRj
X3Bvd2VyX2RvbWFpbnMobmV3X2NydGNfc3RhdGUpOwo+ICAJCX0KPiAtCj4gLQkJaWYgKCFuZWVk
c19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiAtCQkJY29udGludWU7Cj4gLQo+IC0JCWludGVs
X3ByZV9wbGFuZV91cGRhdGUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlKTsKPiAtCj4g
LQkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkgewo+IC0JCQlpbnRlbF9jcnRjX2Rp
c2FibGVfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPiAtCj4gLQkJCS8qCj4gLQkJCSAqIFdlIG5lZWQg
dG8gZGlzYWJsZSBwaXBlIENSQyBiZWZvcmUgZGlzYWJsaW5nIHRoZSBwaXBlLAo+IC0JCQkgKiBv
ciB3ZSByYWNlIGFnYWluc3QgdmJsYW5rIG9mZi4KPiAtCQkJICovCj4gLQkJCWludGVsX2NydGNf
ZGlzYWJsZV9waXBlX2NyYyhjcnRjKTsKPiAtCj4gLQkJCWRldl9wcml2LT5kaXNwbGF5LmNydGNf
ZGlzYWJsZShvbGRfY3J0Y19zdGF0ZSwgc3RhdGUpOwo+IC0JCQljcnRjLT5hY3RpdmUgPSBmYWxz
ZTsKPiAtCQkJaW50ZWxfZmJjX2Rpc2FibGUoY3J0Yyk7Cj4gLQkJCWludGVsX2Rpc2FibGVfc2hh
cmVkX2RwbGwob2xkX2NydGNfc3RhdGUpOwo+IC0KPiAtCQkJLyoKPiAtCQkJICogVW5kZXJydW5z
IGRvbid0IGFsd2F5cyByYWlzZQo+IC0JCQkgKiBpbnRlcnJ1cHRzLCBzbyBjaGVjayBtYW51YWxs
eS4KPiAtCQkJICovCj4gLQkJCWludGVsX2NoZWNrX2NwdV9maWZvX3VuZGVycnVucyhkZXZfcHJp
dik7Cj4gLQkJCWludGVsX2NoZWNrX3BjaF9maWZvX3VuZGVycnVucyhkZXZfcHJpdik7Cj4gLQo+
IC0JCQkvKiBGSVhNRSB1bmlmeSB0aGlzIGZvciBhbGwgcGxhdGZvcm1zICovCj4gLQkJCWlmICgh
bmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlICYmCj4gLQkJCSAgICAhSEFTX0dNQ0goZGV2X3By
aXYpICYmCj4gLQkJCSAgICBkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MpCj4g
LQkJCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3Moc3RhdGUsCj4gLQkJCQkJ
CQkJICAgICBuZXdfY3J0Y19zdGF0ZSk7Cj4gLQkJfQo+ICAJfQo+ICAKPiArCWludGVsX2NvbW1p
dF9tb2Rlc2V0X2Rpc2FibGVzKHN0YXRlKTsKPiArCj4gIAkvKiBGSVhNRTogRXZlbnR1YWxseSBn
ZXQgcmlkIG9mIG91ciBjcnRjLT5jb25maWcgcG9pbnRlciAqLwo+ICAJZm9yX2VhY2hfbmV3X2lu
dGVsX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKQo+ICAJCWNy
dGMtPmNvbmZpZyA9IG5ld19jcnRjX3N0YXRlOwo+IEBAIC0xNTkyOSw2ICsxNTk1Miw3IEBAIHZv
aWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdikKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5jb21taXRfbW9kZXNldF9lbmFibGVzID0gc2ts
X2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXM7Cj4gIAllbHNlCj4gIAkJZGV2X3ByaXYtPmRpc3BsYXku
Y29tbWl0X21vZGVzZXRfZW5hYmxlcyA9IGludGVsX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXM7Cj4g
Kwo+ICB9Cj4gIAo+ICBzdGF0aWMgaTkxNV9yZWdfdCBpOTE1X3ZnYWNudHJsX3JlZyhzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5k
ZXggNzVhNDJlOGRmNjdlLi5kYjc0ODA4MzFlNTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2
LmgKPiBAQCAtMjg5LDYgKzI4OSw3IEBAIHN0cnVjdCBkcm1faTkxNV9kaXNwbGF5X2Z1bmNzIHsK
PiAgCXZvaWQgKCpjcnRjX2Rpc2FibGUpKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0
Y19zdGF0ZSwKPiAgCQkJICAgICBzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpvbGRfc3RhdGUp
Owo+ICAJdm9pZCAoKmNvbW1pdF9tb2Rlc2V0X2VuYWJsZXMpKHN0cnVjdCBpbnRlbF9hdG9taWNf
c3RhdGUgKnN0YXRlKTsKPiArCXZvaWQgKCpjb21taXRfbW9kZXNldF9kaXNhYmxlcykoc3RydWN0
IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICAJdm9pZCAoKmF1ZGlvX2NvZGVjX2VuYWJs
ZSkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQkgICBjb25zdCBzdHJ1Y3Qg
aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJCSAgIGNvbnN0IHN0cnVjdCBkcm1f
Y29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlKTsKPiAtLSAKPiAyLjE5LjEKPiAKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4