Re: [MPTCP] [PATCH v2] mptcp: sockopt: pass whitelisted setsockopt to subflows

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> On Fri, 16 Aug 2019, Florian Westphal wrote:
> 
> > This allows to set tcp congestion control algorithm on all subflows.
> > 
> > In the future we could keep a record of sockopts so we can "replay"
> > them when another subflow is added at a later point in time.
> > 
> > Only TCP_CONGESTION is allowed at the moment, as some available
> > TCP knobs either have undesireable behaviour or should be later
> > implemented at the mptcp level rather than passing them through to
> > the subflows (TCP_CORK for example).
> > 
> > getsockopt is disabled for the time being to not expose a particular
> > behaviour ("first subflow on list") at this time.
> > 
> > v2: disable getsockopt, restrict setsockopt via whitelist.
> 
> As Florian mentioned on the call today, we definitely want to merge the
> getsockopt fix.
> 
> As for the setsockopt part, if TCP_CONGESTION is sufficiently useful to
> enough users, we could consider merging it. My slight hesitation is that the
> potential "replay" behavior change in the future could come as a surprise,
> and if we start out with this ability to set options on all subflows then we
> have to be careful and consistent about how it interacts with per-subflow
> options later. Anyone know if TCP_CONGESTION is a priority?

Its not.

Lets drop this, I will respin with the getsockopt fix only.

Alternatively, Matthieu -- if you can just apply the getsockopt part
of this patch that works for me too.