From: Rob Herring <robh@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Phil Reid <preid@electromag.com.au>,
jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, mark.rutland@arm.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-binding: iio: Add optional label property
Date: Thu, 29 Aug 2019 18:02:07 -0500 [thread overview]
Message-ID: <20190829230207.GA22979@bogus> (raw)
In-Reply-To: <a30b6dca-c598-135a-0559-1018dd5f5fde@xilinx.com>
On Wed, Aug 28, 2019 at 08:09:19AM +0200, Michal Simek wrote:
> On 27. 08. 19 5:35, Phil Reid wrote:
> > This optional property defines a symbolic name for the device.
> >
> > Signed-off-by: Phil Reid <preid@electromag.com.au>
> > ---
> > Documentation/devicetree/bindings/iio/iio-bindings.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/iio-bindings.txt b/Documentation/devicetree/bindings/iio/iio-bindings.txt
> > index 68d6f8ce063b..ffeae5aad8b5 100644
> > --- a/Documentation/devicetree/bindings/iio/iio-bindings.txt
> > +++ b/Documentation/devicetree/bindings/iio/iio-bindings.txt
> > @@ -18,12 +18,17 @@ Required properties:
> > with a single IIO output and 1 for nodes with multiple
> > IIO outputs.
> >
> > +Optional properties:
> > +label: A symbolic name for the device.
> > +
> > +
> > Example for a simple configuration with no trigger:
> >
> > adc: voltage-sensor@35 {
> > compatible = "maxim,max1139";
> > reg = <0x35>;
> > #io-channel-cells = <1>;
> > + label = "adc_voltage_sensor";
> > };
> >
> > Example for a configuration with trigger:
> >
>
> Just for the record. This patch has been created based on initial
> discussion about label property. And Rob had not problem with using
> label in connection to ina226. https://lkml.org/lkml/2019/8/27/1213
I didn't, but based on the name here I'm less convinced. 'label' is
supposed to be for needing to distinguish between more than 1 of
something. A name like 'adc_voltage_sensor' doesn't really.
Rob
next prev parent reply other threads:[~2019-08-29 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 3:35 [PATCH 0/2] iio: core: Add optional symbolic label to device attributes Phil Reid
2019-08-27 3:35 ` [PATCH 1/2] dt-binding: iio: Add optional label property Phil Reid
2019-08-27 6:10 ` Michal Simek
2019-08-28 6:09 ` Michal Simek
2019-08-29 23:02 ` Rob Herring [this message]
2019-08-30 1:01 ` Phil Reid
2019-08-30 12:34 ` Rob Herring
2019-08-31 10:19 ` Phil Reid
2019-09-08 12:14 ` Jonathan Cameron
2019-08-27 3:35 ` [PATCH 2/2] iio: core: Add optional symbolic label to device attributes Phil Reid
2019-09-08 12:17 ` Jonathan Cameron
2019-09-09 7:45 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829230207.GA22979@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.