All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] xfs: remove all *_ITER_ABORT values
Date: Fri, 30 Aug 2019 10:41:55 +1000	[thread overview]
Message-ID: <20190830004155.GZ1119@dread.disaster.area> (raw)
In-Reply-To: <20190830003007.GU5354@magnolia>

On Thu, Aug 29, 2019 at 05:30:07PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Use -ECANCELED to signal "stop iterating" instead of these magical
> *_ITER_ABORT values, since it's duplicative.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2019-08-30  0:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30  0:25 [PATCH v2 0/2] xfs: get rid of _ITER_{ABORT,CONTINUE} Darrick J. Wong
2019-08-30  0:30 ` [PATCH 1/2] xfs: remove all *_ITER_ABORT values Darrick J. Wong
2019-08-30  0:41   ` Dave Chinner [this message]
2019-08-30  0:30 ` [PATCH 2/2] xfs: remove all *_ITER_CONTINUE values Darrick J. Wong
2019-08-30  0:42   ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2019-08-29 16:21 [PATCH 0/2] xfs: get rid of _ITER_{ABORT,CONTINUE} Darrick J. Wong
2019-08-29 16:22 ` [PATCH 1/2] xfs: remove all *_ITER_ABORT values Darrick J. Wong
2019-08-29 22:00   ` Dave Chinner
2019-08-29 22:13     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190830004155.GZ1119@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.