From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7DF3C3A5A4 for ; Fri, 30 Aug 2019 09:51:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA7B621721 for ; Fri, 30 Aug 2019 09:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rdg3Ylk3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA7B621721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W/ErmY7AwLba0WM2lxZaAuz9iGQ24+9EcDWzBs0F3dI=; b=Rdg3Ylk3dHM1oz +dActDvh2ZN/dPNQ69akQb43NIOMmiLXKI2U4NQ06z/0iF8tbATxxTAY1VWpeDYBLdoIXo/7BuqcY dAOrg4D3VrRgZi/r1jeeYEiohE2AAFhdGWM9IcgdZ1pldMsVKkZAlub1dFSGf+1ctlAoDGTE4F/dB dF1JipksL7HrTla8mAAT2FdO1e8y+thwKa8XKJtFrDBReZoEU4mcvsuNqTBl6jocb2AZWfc4P7woz Td5kiHPomwzcnzekFj2ivQCZNgBVddwpPuSk19O2cprho/e2NZpSJfitd4tAdNq2Hfu8Z4aMxpSq7 9eL2rdYb/PWmQvuNafxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3dYt-0000oQ-P7; Fri, 30 Aug 2019 09:51:19 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3dYq-0000o5-QK for linux-mtd@lists.infradead.org; Fri, 30 Aug 2019 09:51:18 +0000 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 7C221FF807; Fri, 30 Aug 2019 09:51:01 +0000 (UTC) Date: Fri, 30 Aug 2019 11:51:00 +0200 From: Miquel Raynal To: masonccyang@mxic.com.tw Subject: Re: [PATCH] Add support for Macronix NAND randomizer Message-ID: <20190830115100.3fec9bf1@xps13> In-Reply-To: References: <1566280428-4159-1-git-send-email-masonccyang@mxic.com.tw> <20190824130329.68f310aa@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_025117_002909_64E6B060 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at, linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, tglx@linutronix.de, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFzb24sCgptYXNvbmNjeWFuZ0BteGljLmNvbS50dyB3cm90ZSBvbiBUaHUsIDI5IEF1ZyAy MDE5IDE3OjA3OjUxICswODAwOgoKPiBIaSBNaXF1ZWwsIAo+IAo+IAo+ID4gPiAKPiA+ID4gSWYg c3VicGFnZSB3cml0ZSBub3QgYXZhaWxhYmxlIHdpdGggaGFyZHdhcmUgRUNDLCBmb3IgZXhhbXBs ZSwKPiA+ID4gTkFORCBjaGlwIG9wdGlvbnMgTkFORF9OT19TVUJQQUdFX1dSSVRFIGJlIHNldCBp biBkcml2ZXIgYW5kCj4gPiA+IHJhbmRvbWl6ZXIgZnVuY3Rpb24gaXMgcmVjb21tZW5kZWQgZm9y IGhpZ2gtcmVsaWFiaWxpdHkuCj4gPiA+IERyaXZlciBjaGVja3MgYnl0ZSAxNjcgb2YgVmVuZG9y IEJsb2NrcyBpbiBPTkZJIHBhcmFtZXRlciBwYWdlIHRhYmxlCj4gPiA+IHRvIHNlZSBpZiB0aGlz IGhpZ2gtcmVsaWFiaWxpdHkgZnVuY3Rpb24gaXMgc3VwcG9ydGVkLgo+ID4gPiAgIAo+ID4gCj4g PiBZb3UgZGlkIG5vdCBmbGFnZ2VkIHRoaXMgcGF0Y2ggYXMgYSB2MiBhbmQgZm9yZ290IGFib3V0 IHRoZSBjaGFuZ2Vsb2cuCj4gPiBZb3UgZGlkIG5vdCBsaXN0ZW4gdG8gb3VyIGNvbW1lbnRzIGlu IHRoZSBsYXN0IHZlcnNpb24gbmVpdGhlci4gSSB3YXMKPiA+IG9wZW4gdG8gYSBzb2x1dGlvbiB3 aXRoIGEgc3BlY2lmaWMgRFQgcHJvcGVydHkgZm9yIHdhcm5lZCB1c2VycyBidXQgSQo+ID4gZG9u J3Qgc2VlIGl0IGNvbWluZy4KPiA+ICAgCj4gCj4gQmFzZWQgb24geW91ciBjb21tZW50cyBieSBz cGVjaWZpYyBEVCBwcm9wZXJ0eSBmb3IgcmFuZG9taXplciBzdXBwb3J0Lgo+IHRvIGFkZCBhIG5l dyBwcm9wZXJ0eSBpbiBjaGlsZHJlbiBub2RlczoKPiAKPiBpLmUsLgo+IAo+IG5hbmQ6IG5hbmQt Y29udHJvbGxlckA0M2MzMDAwMCB7Cj4gCj4gICAgICAgICAgICAgICAgIG5hbmRAMCB7Cj4gICAg ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDA+Owo+ICAgICAgICAgICAgICAgICAgICAgICAg IG5hbmQtcmVsaWFiaWxpdHkgPSAicmFuZG9taXplciI7CgogICAgICAgICAgICAgICAgICAgICAg ICAgIG14aWMsZW5hYmxlLXJhbmRvbWl6ZXItb3RwOwoKV291bGQgYmUgYmV0dGVyICh3aXRoIHRo ZSBwcm9wZXIgZG9jdW1lbnRhdGlvbiBpbiB0aGUgYmluZGluZ3MpLgoKClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5E5C3A5A4 for ; Fri, 30 Aug 2019 09:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DADF721670 for ; Fri, 30 Aug 2019 09:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbfH3JvF convert rfc822-to-8bit (ORCPT ); Fri, 30 Aug 2019 05:51:05 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35737 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbfH3JvF (ORCPT ); Fri, 30 Aug 2019 05:51:05 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 7C221FF807; Fri, 30 Aug 2019 09:51:01 +0000 (UTC) Date: Fri, 30 Aug 2019 11:51:00 +0200 From: Miquel Raynal To: masonccyang@mxic.com.tw Cc: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, frieder.schrempf@kontron.de, juliensu@mxic.com.tw, kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, richard@nod.at, tglx@linutronix.de, vigneshr@ti.com Subject: Re: [PATCH] Add support for Macronix NAND randomizer Message-ID: <20190830115100.3fec9bf1@xps13> In-Reply-To: References: <1566280428-4159-1-git-send-email-masonccyang@mxic.com.tw> <20190824130329.68f310aa@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mason, masonccyang@mxic.com.tw wrote on Thu, 29 Aug 2019 17:07:51 +0800: > Hi Miquel, > > > > > > > > If subpage write not available with hardware ECC, for example, > > > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and > > > randomizer function is recommended for high-reliability. > > > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table > > > to see if this high-reliability function is supported. > > > > > > > You did not flagged this patch as a v2 and forgot about the changelog. > > You did not listen to our comments in the last version neither. I was > > open to a solution with a specific DT property for warned users but I > > don't see it coming. > > > > Based on your comments by specific DT property for randomizer support. > to add a new property in children nodes: > > i.e,. > > nand: nand-controller@43c30000 { > > nand@0 { > reg = <0>; > nand-reliability = "randomizer"; mxic,enable-randomizer-otp; Would be better (with the proper documentation in the bindings). Thanks, Miquèl