From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH] mptcp: fix mptcp socket cleanup
Date: Fri, 30 Aug 2019 14:29:21 +0200 [thread overview]
Message-ID: <20190830122921.GP20113@breakpoint.cc> (raw)
In-Reply-To: e88e1256082439491fbfb0b92e254a692b32af7f.1567167420.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> + /* when assiging the token to the msk, we need to held
> + * an additional reference, will be released at msk token
> + * destruction time
> + */
Unrelated to your patch, but I think this is wrong.
We should have implicit reference for the token.
Taking a reference makes no sense because the token lifetime is limited by
the mptcp socket -- if the mptcp socket is closing, we remove the token too.
token_release() function makes no sense to me -- afaics all callers
have a pointer to the msk they want to put the reference for.
I'll have a look into cleaning that up after respinning a squashable
version of the token refactoring.
next reply other threads:[~2019-08-30 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 12:29 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-30 12:17 [MPTCP] [PATCH] mptcp: fix mptcp socket cleanup Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830122921.GP20113@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.