From: Joerg Roedel <jroedel@suse.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org, Jinyu Qi <jinyuqi@huawei.com>,
Eric Dumazet <edumazet@google.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on
Date: Fri, 30 Aug 2019 15:22:39 +0200 [thread overview]
Message-ID: <20190830132239.GK17192@suse.de> (raw)
In-Reply-To: <3ffd6989-229b-9c67-d9fb-7a8e413c1336@arm.com>
On Fri, Aug 30, 2019 at 01:27:25PM +0100, Robin Murphy wrote:
> On 30/08/2019 11:49, Joerg Roedel wrote:
> > Looks good to me, but adding Robin for his opinion.
>
> Sounds reasonable to me too - that should also be true for the majority of
> Arm systems that we know of. Will suggested that atomic_try_cmpxchg() might
> be relevant, but AFAICS that's backwards compared to what we want to do
> here, which I guess is more of an "atomic_unlikely_cmpxchg".
>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Great, thanks for looking into it, Robin.
Applied now, thanks Eric.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Eric Dumazet <edumazet@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Jinyu Qi <jinyuqi@huawei.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on
Date: Fri, 30 Aug 2019 15:22:39 +0200 [thread overview]
Message-ID: <20190830132239.GK17192@suse.de> (raw)
In-Reply-To: <3ffd6989-229b-9c67-d9fb-7a8e413c1336@arm.com>
On Fri, Aug 30, 2019 at 01:27:25PM +0100, Robin Murphy wrote:
> On 30/08/2019 11:49, Joerg Roedel wrote:
> > Looks good to me, but adding Robin for his opinion.
>
> Sounds reasonable to me too - that should also be true for the majority of
> Arm systems that we know of. Will suggested that atomic_try_cmpxchg() might
> be relevant, but AFAICS that's backwards compared to what we want to do
> here, which I guess is more of an "atomic_unlikely_cmpxchg".
>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Great, thanks for looking into it, Robin.
Applied now, thanks Eric.
next prev parent reply other threads:[~2019-08-30 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 13:13 [PATCH] iommu/iova: avoid false sharing on fq_timer_on Eric Dumazet via iommu
2019-08-28 13:13 ` Eric Dumazet
2019-08-30 10:49 ` Joerg Roedel
2019-08-30 10:49 ` Joerg Roedel
2019-08-30 12:27 ` Robin Murphy
2019-08-30 12:27 ` Robin Murphy
2019-08-30 13:22 ` Joerg Roedel [this message]
2019-08-30 13:22 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830132239.GK17192@suse.de \
--to=jroedel@suse.de \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jinyuqi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.