From: Jason Gunthorpe <jgg@ziepe.ca>
To: Seunghun Han <kkamagui@gmail.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM
Date: Fri, 30 Aug 2019 11:38:52 -0300 [thread overview]
Message-ID: <20190830143852.GA302@ziepe.ca> (raw)
In-Reply-To: <CAHjaAcQ0MrPCZUit7s0Rmqpwpp0w5jiYjNUNEEm2yc1AejZ3ng@mail.gmail.com>
On Fri, Aug 30, 2019 at 10:54:59PM +0900, Seunghun Han wrote:
> When I tested this patch in my machine, it seemed that ACPI NVS was
> saved after TPM CRB driver sent "TPM2_Shutdown(STATE)" to the fTPM
> while suspending. Then, ACPI NVS was restored while resuming.
> After resuming, PCRs didn't change and TPM2 tools such as
> tpm2_pcrlist, tpm2_extend, tpm2_getrandoms worked well.
> So, according to my test result, it seems that the patch doesn't
> create bugs and race during resume.
I have a feeling that is shear luck of link time ordering and not guarenteed??
Jason
next prev parent reply other threads:[~2019-08-30 14:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:56 [PATCH 0/2] Enhance support for the AMD's fTPM Seunghun Han
2019-08-30 9:56 ` [PATCH 1/2] tpm: tpm_crb: enhance command and response buffer size calculation code Seunghun Han
2019-08-30 9:56 ` [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM Seunghun Han
2019-08-30 12:43 ` Jason Gunthorpe
2019-08-30 13:54 ` Seunghun Han
2019-08-30 14:20 ` Safford, David (GE Global Research, US)
2019-08-30 16:54 ` Seunghun Han
2019-08-30 17:58 ` Safford, David (GE Global Research, US)
2019-09-02 13:53 ` Jarkko Sakkinen
2019-09-02 22:42 ` Seunghun Han
2019-09-03 16:10 ` Jarkko Sakkinen
2019-09-03 17:43 ` Seunghun Han
2019-09-03 9:56 ` Seunghun Han
2019-09-03 9:59 ` Seunghun Han
2019-09-03 12:26 ` Safford, David (GE Global Research, US)
2019-09-03 18:14 ` Seunghun Han
2019-09-03 16:16 ` Jarkko Sakkinen
2019-09-03 18:52 ` Seunghun Han
2019-08-30 14:38 ` Jason Gunthorpe [this message]
2019-08-30 16:13 ` Seunghun Han
2019-08-31 22:27 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830143852.GA302@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kkamagui@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.