From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] pseries: do not allow memory-less/cpu-less NUMA node
Date: Fri, 30 Aug 2019 17:34:13 +0100 [thread overview]
Message-ID: <20190830163413.GH4674@redhat.com> (raw)
In-Reply-To: <20190830161345.22436-1-lvivier@redhat.com>
On Fri, Aug 30, 2019 at 06:13:45PM +0200, Laurent Vivier wrote:
> When we hotplug a CPU on memory-less/cpu-less node, the linux kernel
> crashes.
>
> This happens because linux kernel needs to know the NUMA topology at
> start to be able to initialize the distance lookup table.
>
> On pseries, the topology is provided by the firmware via the existing
> CPUs and memory information. Thus a node without memory and CPU cannot be
> discovered by the kernel.
>
> To avoid the kernel crash, do not allow to start pseries with empty
> nodes.
This describes one possible guest OS. Is there any reasonable chance
that a non-Linux guest might be able to handle this situation correctly,
or do you expect any guest to have the same restriction ?
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/ppc/spapr.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-08-30 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 16:13 [Qemu-devel] [PATCH] pseries: do not allow memory-less/cpu-less NUMA node Laurent Vivier
2019-08-30 16:34 ` Daniel P. Berrangé [this message]
2019-08-30 17:45 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-09-02 6:27 ` David Gibson
2019-09-02 8:57 ` Daniel P. Berrangé
2019-09-02 9:11 ` David Gibson
2019-09-02 13:58 ` Greg Kurz
2019-09-02 9:14 ` [Qemu-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830163413.GH4674@redhat.com \
--to=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.