From: Leon Romanovsky <leon@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
Jiri Pirko <jiri@mellanox.com>, Ray Jui <ray.jui@broadcom.com>
Subject: Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().
Date: Sat, 31 Aug 2019 10:41:43 +0300 [thread overview]
Message-ID: <20190831074143.GI12611@unreal> (raw)
In-Reply-To: <CACKFLiku-5Q6mBFgd2L_gTqZ=UWUf_HTUeC_n6=aVH+V_o1p4g@mail.gmail.com>
On Fri, Aug 30, 2019 at 09:00:27AM -0700, Michael Chan wrote:
> On Fri, Aug 30, 2019 at 2:18 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Mon, Aug 26, 2019 at 09:00:45AM +0300, Leon Romanovsky wrote:
> > > On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote:
> > > > Refactor the hardware/firmware configuration portion in
> > > > bnxt_sriov_enable() into a new function bnxt_cfg_hw_sriov(). This
> > > > new function can be called after a firmware reset to reconfigure the
> > > > VFs previously enabled.
> > >
> > > I wonder what does it mean for already bound VFs to vfio driver?
> > > Will you rebind them as well? Can I assume that FW error in one VF
> > > will trigger "restart" of other VFs too?
> >
> > Care to reply?
> >
> >
> Sorry, I missed your email earlier.
>
> A firmware reset/recovery has no direct effect on a VF or any function
> if it is just idle. The PCI interface of any function does not get
> reset.
>
> If a VF driver (Linux VF driver, DPDK driver, etc) has initialized on
> that function, meaning it has exchanged messages with firmware to
> register itself and to allocate resources (such as rings), then the
> firmware reset will require all those resources to be re-discovered
> and re-initialized. These VF resources are initially assigned by the
> PF. So this refactored function on the PF is to re-assign these
> resources back to the VF after the firmware reset. Again, if the VF
> is just bound to vfio and is idle, there is no effect.
Thanks for explaining the flow.
next prev parent reply other threads:[~2019-08-31 7:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 3:54 [PATCH net-next 00/14] bnxt_en: health and error recovery Michael Chan
2019-08-26 3:54 ` [PATCH net-next 01/14] bnxt_en: Suppress all error messages in hwrm_do_send_msg() in silent mode Michael Chan
2019-08-26 5:15 ` David Miller
2019-08-26 6:17 ` Michael Chan
2019-08-26 3:54 ` [PATCH net-next 02/14] bnxt_en: Prepare bnxt_init_one() to be called multiple times Michael Chan
2019-08-26 3:54 ` [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable() Michael Chan
2019-08-26 5:36 ` David Miller
2019-08-26 6:06 ` Michael Chan
2019-08-26 6:00 ` Leon Romanovsky
2019-08-30 9:18 ` Leon Romanovsky
2019-08-30 16:00 ` Michael Chan
2019-08-31 7:41 ` Leon Romanovsky [this message]
2019-08-26 3:54 ` [PATCH net-next 04/14] bnxt_en: Handle firmware reset status during IF_UP Michael Chan
2019-08-26 5:47 ` David Miller
2019-08-26 3:54 ` [PATCH net-next 05/14] bnxt_en: Discover firmware error recovery capabilities Michael Chan
2019-08-26 5:49 ` David Miller
2019-08-26 6:23 ` Michael Chan
2019-08-26 3:54 ` [PATCH net-next 06/14] bnxt_en: Pre-map the firmware health monitoring registers Michael Chan
2019-08-26 3:54 ` [PATCH net-next 07/14] bnxt_en: Enable health monitoring Michael Chan
2019-08-26 3:54 ` [PATCH net-next 08/14] bnxt_en: Add BNXT_STATE_IN_FW_RESET state and pf->registered_vfs Michael Chan
2019-08-26 5:59 ` David Miller
2019-08-26 3:55 ` [PATCH net-next 09/14] bnxt_en: Add new FW devlink_health_reporter Michael Chan
2019-08-26 3:55 ` [PATCH net-next 10/14] bnxt_en: Handle RESET_NOTIFY async event from firmware Michael Chan
2019-08-26 3:55 ` [PATCH net-next 11/14] bnxt_en: Retain user settings on a VF after RESET_NOTIFY event Michael Chan
2019-08-26 3:55 ` [PATCH net-next 12/14] bnxt_en: Do not send firmware messages if firmware is in error state Michael Chan
2019-08-26 3:55 ` [PATCH net-next 13/14] bnxt_en: Add RESET_FW state logic to bnxt_fw_reset_task() Michael Chan
2019-08-26 3:55 ` [PATCH net-next 14/14] bnxt_en: Add FW fatal devlink_health_reporter Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831074143.GI12611@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.