From: Stephen Hemminger <stephen@networkplumber.org>
To: <tomaspaukrt@email.cz>
Cc: <netdev@vger.kernel.org>
Subject: Re: iproute2: tc: potential buffer overflow
Date: Sat, 31 Aug 2019 08:37:51 -0700 [thread overview]
Message-ID: <20190831083751.3814ee37@hermes.lan> (raw)
In-Reply-To: <8fo.ZWfD.3kvedbSyU2M.1TQd9t@seznam.cz>
On Sat, 31 Aug 2019 15:13:27 +0200 (CEST)
<tomaspaukrt@email.cz> wrote:
> Hi,
>
> there are two potentially dangerous calls of strcpy function in the program "tc". In the attachment is a patch that fixes this issue.
>
> Tomas
This looks correct.
Please fix with strlcpy() instead; that is clearer.
Plus you can use XT_EXTENSION_MAX_NAMELEN here (optional).
next prev parent reply other threads:[~2019-08-31 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 13:13 iproute2: tc: potential buffer overflow tomaspaukrt
2019-08-31 15:37 ` Stephen Hemminger [this message]
2019-09-07 13:43 ` tomaspaukrt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831083751.3814ee37@hermes.lan \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=tomaspaukrt@email.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.