From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nft_socket: fix erroneous socket assignment
Date: Sat, 31 Aug 2019 12:41:00 +0200 [thread overview]
Message-ID: <20190831104100.GV20113@breakpoint.cc> (raw)
In-Reply-To: <20190831101453.1869-1-ffmancera@riseup.net>
Fernando Fernandez Mancera <ffmancera@riseup.net> wrote:
> This socket assignment was unnecessary and also added a missing sock_gen_put().
The socket assignment is wrong, see skb_orphan():
When skb->destructor callback is not set, but skb->sk is set, this hits BUG().
You could add a 'Link: ' to the bugzilla ticket if you like.
Patch looks good, thanks for fixing this Fernando!
prev parent reply other threads:[~2019-08-31 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 10:14 [PATCH nf-next] netfilter: nft_socket: fix erroneous socket assignment Fernando Fernandez Mancera
2019-08-31 10:18 ` Fernando Fernandez Mancera
2019-08-31 10:41 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831104100.GV20113@breakpoint.cc \
--to=fw@strlen.de \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.