Re: [warrior 14/23] libopus: Limit forcing ARM mode ISA to v5 only

[Adrian Bunk <bunk@stusta.de>]

On Sat, Aug 31, 2019 at 02:31:35PM -0700, Armin Kuster wrote:
> From: Khem Raj <raj.khem@gmail.com>
> 
> This lets newer armv7+ still use thumb2 ISA
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb b/meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb
> index fb9bdc7..1512a1d 100644
> --- a/meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb
> +++ b/meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb
> @@ -50,6 +50,6 @@ python () {
>  #| {standard input}:761: Error: selected processor does not support Thumb mode `smull fp,r2,r3,r9'
>  #| {standard input}:773: Error: selected processor does not support Thumb mode `smull fp,r3,r5,r8'
>  #| make[2]: *** [celt/celt.lo] Error 1
> -ARM_INSTRUCTION_SET = "arm"
> +ARM_INSTRUCTION_SET_armv5 = "arm"
>...

This is an optimization, not something that should go into stable.

It also looks buggy, as if it would break the build for armv4t
and some armv6.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed