Re: [PATCH v1 5/5] RDMA/nldev: ib_pd can be pointed by multiple ib_ucontext

[Yuval Shaia <yuval.shaia@oracle.com>]

On Thu, Aug 29, 2019 at 02:27:13PM +0000, Jason Gunthorpe wrote:
> On Thu, Aug 29, 2019 at 10:13:03AM +0300, Yuval Shaia wrote:
> > On Wed, Aug 28, 2019 at 07:28:23PM +0000, Jason Gunthorpe wrote:
> > > On Wed, Aug 28, 2019 at 09:56:46PM +0300, Yuval Shaia wrote:
> > > > On Wed, Aug 28, 2019 at 01:53:12PM +0000, Jason Gunthorpe wrote:
> > > > > On Wed, Aug 28, 2019 at 12:15:33PM +0300, Yuval Shaia wrote:
> > > > > >  static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > > > > >  			     struct rdma_restrack_entry *res, uint32_t port)
> > > > > >  {
> > > > > >  	struct ib_pd *pd = container_of(res, struct ib_pd, res);
> > > > > >  	struct ib_device *dev = pd->device;
> > > > > > +	struct nlattr *table_attr = NULL;
> > > > > > +	struct nlattr *entry_attr = NULL;
> > > > > > +	struct context_id *ctx_id;
> > > > > > +	struct context_id *tmp;
> > > > > > +	LIST_HEAD(pd_context_ids);
> > > > > > +	int ctx_count = 0;
> > > > > >  
> > > > > >  	if (has_cap_net_admin) {
> > > > > >  		if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY,
> > > > > > @@ -633,10 +709,38 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > > > > >  	if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_PDN, res->id))
> > > > > >  		goto err;
> > > > > >  
> > > > > > -	if (!rdma_is_kernel_res(res) &&
> > > > > > -	    nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_CTXN,
> > > > > > -			pd->uobject->context->res.id))
> > > > > > -		goto err;
> > > > > 
> > > > > How do earlier patches compile?
> > > > 
> > > > They did not
> > > 
> > > That is not OK
> > 
> > Sorry, i probably misunderstood you, what patches are you referring to?
> 
> Just make sure every patch in the series compiles.

Ok got it.
Will change the order of the patches in the set and send v2.

> 
> Jason