From: Pavel Machek <pavel@ucw.cz>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger
Date: Sun, 1 Sep 2019 19:23:23 +0200 [thread overview]
Message-ID: <20190901172323.GB1005@bug> (raw)
In-Reply-To: <1567090164-6819-1-git-send-email-akinobu.mita@gmail.com>
Hi!
> Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute.
>
> Enabling LED CPU trigger on systems with thousands of CPUs easily hits
> PAGE_SIZE limit, and makes it impossible to see all available LED triggers
> and which trigger is currently activated.
>
> This converts /sys/class/leds/<led>/trigger to bin attribute and removes
> the PAGE_SIZE limitation.
>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Nothing obviously wrong from a quick look...
Acked-by: Pavel Machek <pavel@ucw.cz>
Thanks a lot for doing this!
I believe we should cc Greg here.
BTW if you care about cpuled trigger... it would be cool to turn it into one trigger and pass
a cpu number as a parameter. It is good to see this limit fixed, but real solution is to
register one trigger per driver.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-09-01 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:49 [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-01 16:53 ` Jacek Anaszewski
2019-09-02 18:12 ` Greg KH
2019-09-02 18:47 ` Jacek Anaszewski
2019-09-02 19:08 ` Greg KH
2019-09-03 13:55 ` Akinobu Mita
2019-09-03 14:07 ` Greg KH
2019-09-03 14:21 ` Akinobu Mita
2019-09-03 14:44 ` Greg KH
2019-09-03 18:18 ` Jacek Anaszewski
2019-09-03 18:32 ` Greg KH
2019-09-03 20:30 ` Pavel Machek
2019-09-01 17:23 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-12 14:39 [PATCH] leds: fix /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-12 14:39 ` [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-12 17:15 ` Jacek Anaszewski
2019-09-13 0:34 ` Akinobu Mita
2019-09-13 5:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901172323.GB1005@bug \
--to=pavel@ucw.cz \
--cc=akinobu.mita@gmail.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.