From: Lee Jones <lee.jones@linaro.org>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: ezx-pcap: replace mutex_lock with spin_lock
Date: Mon, 2 Sep 2019 09:38:05 +0100 [thread overview]
Message-ID: <20190902083805.GP4804@dell> (raw)
In-Reply-To: <20190813103133.8354-1-huangfq.daxian@gmail.com>
On Tue, 13 Aug 2019, Fuqian Huang wrote:
> As mutex_lock might sleep.
> Function pcap_adc_irq is an interrupt handler.
> The use of mutex_lock in pcap_adc_irq may cause sleep
> in IRQ context.
> Replace mutex_lock with spin_lock to avoid this.
No one has complained explaining why this might be a bad idea and the
premise is sound enough.
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-09-02 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:31 [PATCH] mfd: ezx-pcap: replace mutex_lock with spin_lock Fuqian Huang
2019-09-02 8:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902083805.GP4804@dell \
--to=lee.jones@linaro.org \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.