From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 20/21] drm/dp: Fix a couple of whitespace issues Date: Mon, 2 Sep 2019 13:10:39 +0200 Message-ID: <20190902111039.GC19263@ulmo> References: <20190805122350.8838-1-thierry.reding@gmail.com> <20190805122350.8838-20-thierry.reding@gmail.com> <1565270327.3656.12.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1346602326==" Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA9EE8981B for ; Mon, 2 Sep 2019 11:10:43 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id l11so4769204wrx.5 for ; Mon, 02 Sep 2019 04:10:43 -0700 (PDT) In-Reply-To: <1565270327.3656.12.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1346602326== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rQ2U398070+RC21q" Content-Disposition: inline --rQ2U398070+RC21q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 08, 2019 at 03:18:47PM +0200, Philipp Zabel wrote: > On Mon, 2019-08-05 at 14:23 +0200, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Remove a gratuituous blank line in one place and add a blank line in > > another to improve readability. >=20 > Seems like the comment description is outdated here as well. Indeed. I've had these patches in a development branch for a very long time because the hardware that I used to test DP support on stopped working and I only recently revived this on a different platform that also has a DP output. Looks like that other blank line had been added by some other commit in the meantime. Fixed in v2. Thanks, Thierry >=20 > > Signed-off-by: Thierry Reding > > --- > > drivers/gpu/drm/drm_dp_helper.c | 1 - > > 1 file changed, 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_h= elper.c > > index 136ee609f2ee..6b4431bade3e 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -216,7 +216,6 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *au= x, u8 request, > > } > > =20 > > ret =3D aux->transfer(aux, &msg); > > - > > if (ret >=3D 0) { > > native_reply =3D msg.reply & DP_AUX_NATIVE_REPLY_MASK; > > if (native_reply =3D=3D DP_AUX_NATIVE_REPLY_ACK) { >=20 > regards > Philipp --rQ2U398070+RC21q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl1s+K8ACgkQ3SOs138+ s6GXHxAAg3pcrfEaDEisDmamrKHC8cY2Au33nC3kT9Pj6zda83Qg9AmS/c+1Dtrs SUP4geXY+/aJ65Nk7FCHVDcG5zlsJfKl4Zv4IbVn27EkuEIfJj8xt79zJKP38ck7 AIb7EyUMg/rzrTyRklDrmhB3uHsjm0spWhAn4+41m9/QtKCMUsoqILtMMfPe4nO/ H/FhSSnv11UnqGNMKptb0dYWhBJ5dW2EwI/yY88q8kTBKnhWqtNeYiKRsHocivq/ 5ubBo7wfTdwRkasjokMuiQHu+TZVtFeeeJD3Hdy+s1cb8YpCvzCI8WtcOxRizmG8 rn60KBcs6Unt0mxTN9ayUE0OWzuIJ6WlHIi6vb8ZDVpiKTk9S/Ljv8Kqq8WWzodg Fr7aRnaYFaNHWjeu1TOACVxfBwtz1SmTmVyKqvTIJeykoyCjtRxMJGMpZ6XgdpQD Mfyx1ICv7HQGZ9WEU02l4fTS7+NSRKEeI2AyDKzsK8WN1qKVMxIXgAeTpVV9ZqZ4 BxbB5lLN7x0DzMbaG7j98SZuzmgiG1M2Ye0EIbjGouxF0hQl3igeBvHYGP5ApC5u IqB7oOO+lFXIO5JtIgr9hJpuBrkQHZ8kNnzDl4kPic1aJcL5OOTpprbXx0Imdecm r+sAtE90rQSF9WbrdBqKHmeXWR0JtXLKYSHM6OXecL54Uf4JwHM= =7y9I -----END PGP SIGNATURE----- --rQ2U398070+RC21q-- --===============1346602326== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1346602326==--