From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: "Maxime Ripard" <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org,
"David Airlie" <airlied@linux.ie>,
amd-gfx@lists.freedesktop.org, "Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sean Paul" <sean@poorly.run>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 3/3] drm/edid: no CEA extension is not an error
Date: Mon, 2 Sep 2019 14:46:51 +0300 [thread overview]
Message-ID: <20190902114651.GS7482@intel.com> (raw)
In-Reply-To: <20190830181652.5b58727b@endymion>
On Fri, Aug 30, 2019 at 06:16:52PM +0200, Jean Delvare wrote:
> It is fine for displays without audio functionality to not implement
> CEA extension in their EDID. Do not return an error in that case,
> instead return 0 as if there was a CEA extension with no audio or
> speaker block.
>
> This fixes half of bug fdo#107825:
> https://bugs.freedesktop.org/show_bug.cgi?id=107825
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/drm_edid.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-5.2.orig/drivers/gpu/drm/drm_edid.c 2019-08-30 17:57:38.199990995 +0200
> +++ linux-5.2/drivers/gpu/drm/drm_edid.c 2019-08-30 18:04:36.840333834 +0200
> @@ -4130,7 +4130,7 @@ int drm_edid_to_sad(struct edid *edid, s
> cea = drm_find_cea_extension(edid);
> if (!cea) {
> DRM_DEBUG_KMS("SAD: no CEA Extension found\n");
> - return -ENOENT;
> + return 0;
> }
Seems reasonable. Maybe the cea_revision<3 branches should alse return 0?
Either way
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> if (cea_revision(cea) < 3) {
> @@ -4191,7 +4191,7 @@ int drm_edid_to_speaker_allocation(struc
> cea = drm_find_cea_extension(edid);
> if (!cea) {
> DRM_DEBUG_KMS("SAD: no CEA Extension found\n");
> - return -ENOENT;
> + return 0;
> }
>
> if (cea_revision(cea) < 3) {
>
> --
> Jean Delvare
> SUSE L3 Support
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-02 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 16:14 [PATCH 0/3] drm/edid: don't log errors on absent CEA SAD blocks Jean Delvare
2019-08-30 16:15 ` [PATCH 1/3] drm/amd: be quiet when no SAD block is found Jean Delvare
2019-08-30 16:15 ` [PATCH 2/3] drm/edid: don't log errors on absent CEA SAD blocks Jean Delvare
2019-08-30 16:18 ` [PATCH 2/3] drm/radeon: be quiet when no SAD block is found Jean Delvare
2019-08-30 16:16 ` [PATCH 3/3] drm/edid: no CEA extension is not an error Jean Delvare
2019-09-02 11:46 ` Ville Syrjälä [this message]
2019-09-02 11:55 ` Jean Delvare
2019-09-02 13:17 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902114651.GS7482@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jdelvare@suse.de \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.