From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/vkms: Use alpha value to blend values. Date: Mon, 2 Sep 2019 15:28:58 +0300 Message-ID: <20190902122858.GU7482@intel.com> References: <20190831172546.GA1972@raspberrypi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8301E89BA3 for ; Mon, 2 Sep 2019 12:29:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190831172546.GA1972@raspberrypi> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sidong Yang Cc: David Airlie , Haneen Mohammed , dri-devel@lists.freedesktop.org, Rodrigo Siqueira , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBBdWcgMzEsIDIwMTkgYXQgMDY6MjU6NDZQTSArMDEwMCwgU2lkb25nIFlhbmcgd3Jv dGU6Cj4gVXNlIGFscGhhIHZhbHVlIHRvIGJsZW5kIHNvdXJjZSB2YWx1ZSBhbmQgZGVzdGluYXRp b24gdmFsdWUgSW5zdGVhZCBvZgo+IGp1c3Qgb3ZlcndyaXRlIHdpdGggc291cmNlIHZhbHVlLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFNpZG9uZyBZYW5nIDxyZWFsd2Fra2FAZ21haWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NvbXBvc2VyLmMgfCAxMyArKysrKysrKysr Ky0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NvbXBvc2VyLmMgYi9k cml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NvbXBvc2VyLmMKPiBpbmRleCBkNTU4NTY5NWM2NGQu LmI3NzYxODVlNWNiNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Nv bXBvc2VyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NvbXBvc2VyLmMKPiBA QCAtNzUsNiArNzUsOSBAQCBzdGF0aWMgdm9pZCBibGVuZCh2b2lkICp2YWRkcl9kc3QsIHZvaWQg KnZhZGRyX3NyYywKPiAgCWludCB5X2xpbWl0ID0geV9zcmMgKyBoX2RzdDsKPiAgCWludCB4X2xp bWl0ID0geF9zcmMgKyB3X2RzdDsKPiAgCj4gKwl1OCAqc3JjLCAqZHN0Owo+ICsJdTMyIGFscGhh LCBpbnZfYWxwaGE7CgpUaGVzZSBjb3VsZCBhbGwgbGl2ZSBpbiBhIHRpZ2h0ZXIgc2NvcGUuCgpB cGFydCBmcm9tIHRoYXQgbGd0bQpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwo+ICAJZm9yIChpID0geV9zcmMsIGlfZHN0ID0g eV9kc3Q7IGkgPCB5X2xpbWl0OyArK2kpIHsKPiAgCQlmb3IgKGogPSB4X3NyYywgal9kc3QgPSB4 X2RzdDsgaiA8IHhfbGltaXQ7ICsraikgewo+ICAJCQlvZmZzZXRfZHN0ID0gZGVzdF9jb21wb3Nl ci0+b2Zmc2V0Cj4gQEAgLTg0LDggKzg3LDE0IEBAIHN0YXRpYyB2b2lkIGJsZW5kKHZvaWQgKnZh ZGRyX2RzdCwgdm9pZCAqdmFkZHJfc3JjLAo+ICAJCQkJICAgICArIChpICogc3JjX2NvbXBvc2Vy LT5waXRjaCkKPiAgCQkJCSAgICAgKyAoaiAqIHNyY19jb21wb3Nlci0+Y3BwKTsKPiAgCj4gLQkJ CW1lbWNweSh2YWRkcl9kc3QgKyBvZmZzZXRfZHN0LAo+IC0JCQkgICAgICAgdmFkZHJfc3JjICsg b2Zmc2V0X3NyYywgc2l6ZW9mKHUzMikpOwo+ICsJCQlzcmMgPSB2YWRkcl9zcmMgKyBvZmZzZXRf c3JjOwo+ICsJCQlkc3QgPSB2YWRkcl9kc3QgKyBvZmZzZXRfZHN0Owo+ICsJCQlhbHBoYSA9IHNy Y1szXSArIDE7Cj4gKwkJCWludl9hbHBoYSA9IDI1NiAtIHNyY1szXTsKPiArCQkJZHN0WzBdID0g KGFscGhhICogc3JjWzBdICsgaW52X2FscGhhICogZHN0WzBdKSA+PiA4Owo+ICsJCQlkc3RbMV0g PSAoYWxwaGEgKiBzcmNbMV0gKyBpbnZfYWxwaGEgKiBkc3RbMV0pID4+IDg7Cj4gKwkJCWRzdFsy XSA9IChhbHBoYSAqIHNyY1syXSArIGludl9hbHBoYSAqIGRzdFsyXSkgPj4gODsKPiArCQkJZHN0 WzNdID0gMHhmZjsKPiAgCQl9Cj4gIAkJaV9kc3QrKzsKPiAgCX0KPiAtLSAKPiAyLjIwLjEKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69924C3A59E for ; Mon, 2 Sep 2019 12:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F8FF20820 for ; Mon, 2 Sep 2019 12:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731608AbfIBM3D (ORCPT ); Mon, 2 Sep 2019 08:29:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:4185 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbfIBM3D (ORCPT ); Mon, 2 Sep 2019 08:29:03 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 05:29:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; d="scan'208";a="176308892" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 02 Sep 2019 05:28:59 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 02 Sep 2019 15:28:58 +0300 Date: Mon, 2 Sep 2019 15:28:58 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sidong Yang Cc: Rodrigo Siqueira , David Airlie , Haneen Mohammed , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vkms: Use alpha value to blend values. Message-ID: <20190902122858.GU7482@intel.com> References: <20190831172546.GA1972@raspberrypi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190831172546.GA1972@raspberrypi> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 31, 2019 at 06:25:46PM +0100, Sidong Yang wrote: > Use alpha value to blend source value and destination value Instead of > just overwrite with source value. > > Signed-off-by: Sidong Yang > --- > drivers/gpu/drm/vkms/vkms_composer.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c > index d5585695c64d..b776185e5cb5 100644 > --- a/drivers/gpu/drm/vkms/vkms_composer.c > +++ b/drivers/gpu/drm/vkms/vkms_composer.c > @@ -75,6 +75,9 @@ static void blend(void *vaddr_dst, void *vaddr_src, > int y_limit = y_src + h_dst; > int x_limit = x_src + w_dst; > > + u8 *src, *dst; > + u32 alpha, inv_alpha; These could all live in a tighter scope. Apart from that lgtm Reviewed-by: Ville Syrjälä > + > for (i = y_src, i_dst = y_dst; i < y_limit; ++i) { > for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { > offset_dst = dest_composer->offset > @@ -84,8 +87,14 @@ static void blend(void *vaddr_dst, void *vaddr_src, > + (i * src_composer->pitch) > + (j * src_composer->cpp); > > - memcpy(vaddr_dst + offset_dst, > - vaddr_src + offset_src, sizeof(u32)); > + src = vaddr_src + offset_src; > + dst = vaddr_dst + offset_dst; > + alpha = src[3] + 1; > + inv_alpha = 256 - src[3]; > + dst[0] = (alpha * src[0] + inv_alpha * dst[0]) >> 8; > + dst[1] = (alpha * src[1] + inv_alpha * dst[1]) >> 8; > + dst[2] = (alpha * src[2] + inv_alpha * dst[2]) >> 8; > + dst[3] = 0xff; > } > i_dst++; > } > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel