All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfsprogs: provide a few compatibility typedefs
Date: Mon, 2 Sep 2019 19:09:40 +0200	[thread overview]
Message-ID: <20190902170940.GA7067@lst.de> (raw)
In-Reply-To: <20190902034349.rzglgsd4aajmhtup@XZHOUW.usersys.redhat.com>

On Mon, Sep 02, 2019 at 11:43:49AM +0800, Murphy Zhou wrote:
> > +/*
> > + * Backards compatibility for users of this header, now that the kernel
> > + * removed these typedefs from xfs_fs.h.
> > + */
> > +typedef struct xfs_bstat xfs_bstat_t;
> > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t;
> > +typedef struct xfs_fsop_geom_v1 xfs_fsop;
> 
> Still got build failure about this one.
> 
> Either change this line to:
> 
> +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t;

Yes, that is correct.  I'm obviously not competent enough to send
userspace patches :)

      reply	other threads:[~2019-09-02 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 15:03 [PATCH v2] xfsprogs: provide a few compatibility typedefs Christoph Hellwig
2019-08-30 15:09 ` Darrick J. Wong
2019-09-02  3:43 ` Murphy Zhou
2019-09-02 17:09   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902170940.GA7067@lst.de \
    --to=hch@lst.de \
    --cc=jencce.kernel@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.