From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C696CC3A5A7 for ; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88838230F2 for ; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zWpp0ekw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88838230F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 33791CB0; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4A02DCAE for ; Mon, 2 Sep 2019 21:38:29 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 011DE756 for ; Mon, 2 Sep 2019 21:38:29 +0000 (UTC) Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABC520828; Mon, 2 Sep 2019 21:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460308; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zWpp0ekwFLO9mEtnMHUAEc17a8bDcIff1Kozu6gDr4uXN3F9z04i1GNSj/QOZ5rKe FuHpA83H1qV8KrwcFIOyzgWaTfrOqG2VvFNMund6t/JQJRgqCUafDAKfxyeOndoZtF quD/TKjyWIqOB1/QEOmWDfYieCsTGdVxuxScOlfE= Date: Mon, 2 Sep 2019 16:38:26 -0500 From: Bjorn Helgaas To: Christoph Hellwig Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h Message-ID: <20190902213826.GI7013@google.com> References: <20190830150756.21305-1-kw@linux.com> <20190830161840.GA9733@infradead.org> <20190902211100.GH7013@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190902211100.GH7013@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Krzysztof Wilczynski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Kelsey Skunberg , Will Deacon , David Woodhouse , linux-arm-kernel@lists.infradead.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org [+cc Kelsey] On Mon, Sep 02, 2019 at 04:11:00PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > > Move ATS function prototypes from include/linux/pci-ats.h to > > > include/linux/pci.h so users only need to include : > > > > Why is that so important? Very few PCI(e) device drivers use ATS, > > so keeping it out of everyones include hell doesn't seem all bad. > > This was my idea, and it wasn't a good one, sorry. > > The ATS, PRI, and PASID interfaces are all sort of related and are > used only by the IOMMU drivers, so it probably makes sense to put them > all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID > stuff is in linux/pci-ats.h. Maybe the right thing would be to move > the ATS stuff to pci-ats.h. > > I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: > Move ATS declarations to linux/pci.h so they're all together") with > the excuse of putting the external ATS interfaces next to > pci_ats_init(). But that really looks like it was a mistake because > pci_ats_init() is a PCI-internal thing and its declaration should > probably be in drivers/pci/pci.h instead. Never mind the pci_ats_init() part; Kelsey has already moved that: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=b92b512a435d _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67D4C3A59E for ; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F29F22CF7 for ; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460310; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vG5YdOVzGS/qkZO/T5MUZM5Tvrhso9OQRNrxoA1V/O2mv9O6IvLkQstnYIG6gD5xO 8eqNzfDkr3rexnP1vRQCEkkH0jnTQegP2YjoAiTv1/EDiu7viCPtIjXUfuc0HJ0slt 0utw5y5XLI/WvunzCX6pQm3fHtkCPcHCqhJ25MD8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727514AbfIBVia (ORCPT ); Mon, 2 Sep 2019 17:38:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:49356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727318AbfIBVi3 (ORCPT ); Mon, 2 Sep 2019 17:38:29 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABC520828; Mon, 2 Sep 2019 21:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460308; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zWpp0ekwFLO9mEtnMHUAEc17a8bDcIff1Kozu6gDr4uXN3F9z04i1GNSj/QOZ5rKe FuHpA83H1qV8KrwcFIOyzgWaTfrOqG2VvFNMund6t/JQJRgqCUafDAKfxyeOndoZtF quD/TKjyWIqOB1/QEOmWDfYieCsTGdVxuxScOlfE= Date: Mon, 2 Sep 2019 16:38:26 -0500 From: Bjorn Helgaas To: Christoph Hellwig Cc: Krzysztof Wilczynski , Will Deacon , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, Robin Murphy , David Woodhouse , linux-arm-kernel@lists.infradead.org, Kelsey Skunberg Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h Message-ID: <20190902213826.GI7013@google.com> References: <20190830150756.21305-1-kw@linux.com> <20190830161840.GA9733@infradead.org> <20190902211100.GH7013@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902211100.GH7013@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Kelsey] On Mon, Sep 02, 2019 at 04:11:00PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > > Move ATS function prototypes from include/linux/pci-ats.h to > > > include/linux/pci.h so users only need to include : > > > > Why is that so important? Very few PCI(e) device drivers use ATS, > > so keeping it out of everyones include hell doesn't seem all bad. > > This was my idea, and it wasn't a good one, sorry. > > The ATS, PRI, and PASID interfaces are all sort of related and are > used only by the IOMMU drivers, so it probably makes sense to put them > all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID > stuff is in linux/pci-ats.h. Maybe the right thing would be to move > the ATS stuff to pci-ats.h. > > I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: > Move ATS declarations to linux/pci.h so they're all together") with > the excuse of putting the external ATS interfaces next to > pci_ats_init(). But that really looks like it was a mistake because > pci_ats_init() is a PCI-internal thing and its declaration should > probably be in drivers/pci/pci.h instead. Never mind the pci_ats_init() part; Kelsey has already moved that: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=b92b512a435d From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D160C3A59E for ; Mon, 2 Sep 2019 21:38:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D71422DBF for ; Mon, 2 Sep 2019 21:38:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SGXZEgy/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zWpp0ekw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D71422DBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GwGSBeafH4M8z7HrcOkY72o89KQZnhuN6awEFc4IPyY=; b=SGXZEgy/yyUfkm GactC2Y94wdk7ENeTmugeu2+dduh0IpiJPTKg+oda8oBkJMlrpf+Hf9kW6RZKnIzWCZz5m/e/pi0j DPj5N+rNH+Q5sGHRqeMKvSKX0tL61IfJDLL6mJTbMx92GKOO+2UU+fenyjMX9HNcjBscgNIHjgqMG FC9Klm9RsQJamrLjlrdjjhDWGDddlqlbytG2cZLQljswWfh7cDGYjDnDkCTvLb26Vw4PfqjxifYja 6boouF62SAz4vyv6LdaYVW2B1CPxmwhFZwNssQm6bgcQl+51vfxJiMCJkkLvmgg4p5Bk0KU9SSEV0 r3ZWdTS9DTbq4p4ECY+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4u1x-0003cx-37; Mon, 02 Sep 2019 21:38:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i4u1t-0003cO-7i for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2019 21:38:30 +0000 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABC520828; Mon, 2 Sep 2019 21:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460308; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zWpp0ekwFLO9mEtnMHUAEc17a8bDcIff1Kozu6gDr4uXN3F9z04i1GNSj/QOZ5rKe FuHpA83H1qV8KrwcFIOyzgWaTfrOqG2VvFNMund6t/JQJRgqCUafDAKfxyeOndoZtF quD/TKjyWIqOB1/QEOmWDfYieCsTGdVxuxScOlfE= Date: Mon, 2 Sep 2019 16:38:26 -0500 From: Bjorn Helgaas To: Christoph Hellwig Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h Message-ID: <20190902213826.GI7013@google.com> References: <20190830150756.21305-1-kw@linux.com> <20190830161840.GA9733@infradead.org> <20190902211100.GH7013@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190902211100.GH7013@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190902_143829_296293_9AE51124 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Wilczynski , linux-pci@vger.kernel.org, Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Kelsey Skunberg , Will Deacon , David Woodhouse , linux-arm-kernel@lists.infradead.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Kelsey] On Mon, Sep 02, 2019 at 04:11:00PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > > Move ATS function prototypes from include/linux/pci-ats.h to > > > include/linux/pci.h so users only need to include : > > > > Why is that so important? Very few PCI(e) device drivers use ATS, > > so keeping it out of everyones include hell doesn't seem all bad. > > This was my idea, and it wasn't a good one, sorry. > > The ATS, PRI, and PASID interfaces are all sort of related and are > used only by the IOMMU drivers, so it probably makes sense to put them > all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID > stuff is in linux/pci-ats.h. Maybe the right thing would be to move > the ATS stuff to pci-ats.h. > > I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: > Move ATS declarations to linux/pci.h so they're all together") with > the excuse of putting the external ATS interfaces next to > pci_ats_init(). But that really looks like it was a mistake because > pci_ats_init() is a PCI-internal thing and its declaration should > probably be in drivers/pci/pci.h instead. Never mind the pci_ats_init() part; Kelsey has already moved that: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=b92b512a435d _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel