All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Prakhar Sinha <prakharsinha2808@gmail.com>
Cc: tobias.niessen@stud.uni-hannover.de, kim.jamie.bradley@gmail.com,
	pakki001@umn.edu, sabrina-gaube@web.de, nishkadg.linux@gmail.com,
	qader.aymen@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Modified nested if blocks.
Date: Tue, 3 Sep 2019 11:33:32 +0200	[thread overview]
Message-ID: <20190903093332.GC12325@kroah.com> (raw)
In-Reply-To: <20190903090240.GA6104@MeraComputer>

On Tue, Sep 03, 2019 at 02:32:40PM +0530, Prakhar Sinha wrote:
> This patch solves the following checkpatch.pl's messages in
> drivers/staging/rts5208/sd.c
> 
> WARNING: line over 80 characters
> 4517: FILE: drivers/staging/rts5208/sd.c:4517:
> +                                               sd_card->sd_lock_status &=
> ~(SD_UNLOCK_POW_ON | SD_SDR_RST);
> 
> WARNING: line over 80 characters
> 4518: FILE: drivers/staging/rts5208/sd.c:4518:
> +                                               goto
> sd_execute_write_cmd_failed;

Please keep the full line without wrapping them in these messages.

And your subject is a big odd, look at the documentation for how to
create a good subject line.

thanks,

greg k-h

      reply	other threads:[~2019-09-03  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03  9:02 [PATCH] staging: rts5208: Modified nested if blocks Prakhar Sinha
2019-09-03  9:33 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903093332.GC12325@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=kim.jamie.bradley@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nishkadg.linux@gmail.com \
    --cc=pakki001@umn.edu \
    --cc=prakharsinha2808@gmail.com \
    --cc=qader.aymen@gmail.com \
    --cc=sabrina-gaube@web.de \
    --cc=tobias.niessen@stud.uni-hannover.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.