From: Ayan Halder <Ayan.Halder@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>
Subject: Re: [PATCH] drm/komeda: Add ACLK rate to sysfs
Date: Tue, 3 Sep 2019 13:46:02 +0000 [thread overview]
Message-ID: <20190903134601.GA9315@arm.com> (raw)
In-Reply-To: <20190828141508.GA6738@jamwan02-TSP300>
On Wed, Aug 28, 2019 at 02:15:15PM +0000, james qian wang (Arm Technology China) wrote:
> Hi Mihail:
>
> Looks good to me.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
>
Pushed to drm-misc-next 5fcd055193c5d4cac6d205bd65e52c957ea057c2
And that verifies my new dim setup. :)
> James.
>
> On Wed, Aug 28, 2019 at 11:03:49AM +0000, Mihail Atanassov wrote:
> > Expose node with the name 'aclk_hz'
> >
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 0142ee991957..e8d67395a3b9 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -91,9 +91,19 @@ config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
> > }
> > static DEVICE_ATTR_RO(config_id);
> >
> > +static ssize_t
> > +aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
> > +{
> > + struct komeda_dev *mdev = dev_to_mdev(dev);
> > +
> > + return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> > +}
> > +static DEVICE_ATTR_RO(aclk_hz);
> > +
> > static struct attribute *komeda_sysfs_entries[] = {
> > &dev_attr_core_id.attr,
> > &dev_attr_config_id.attr,
> > + &dev_attr_aclk_hz.attr,
> > NULL,
> > };
> >
> > --
> > 2.22.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-09-03 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 11:03 [PATCH] drm/komeda: Add ACLK rate to sysfs Mihail Atanassov
2019-08-28 11:03 ` Mihail Atanassov
2019-08-28 14:15 ` james qian wang (Arm Technology China)
2019-08-28 14:15 ` james qian wang (Arm Technology China)
2019-09-03 13:46 ` Ayan Halder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903134601.GA9315@arm.com \
--to=ayan.halder@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Mihail.Atanassov@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.