From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment
Date: Tue, 3 Sep 2019 21:58:33 +0800 [thread overview]
Message-ID: <20190903135833.GB19294@intel.com> (raw)
In-Reply-To: <1567154729-7183-1-git-send-email-wang.yong19@zte.com.cn>
On 08/30, Yong Wang wrote:
>Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just
>before switch statement, the assignment in switch-case statement is
>redundant. Remove it.
>
>Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
>
>Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 03fc1f7..f328d7c 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -4138,7 +4138,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> link.link_speed = ETH_SPEED_NUM_10M;
> else
> link.link_speed = ETH_SPEED_NUM_100M;
>- link.link_duplex = ETH_LINK_FULL_DUPLEX;
> break;
>
> case IXGBE_LINK_SPEED_100_FULL:
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel with 'Cc: stable@dpdk.org' added in the commit log.
prev parent reply other threads:[~2019-09-03 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 8:45 [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment Yong Wang
2019-09-03 13:58 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903135833.GB19294@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.