From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Nadav Amit <namit@vmware.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Marc Orr <marcorr@google.com>
Subject: Re: [kvm-unit-tests PATCH 2/2] x86: nVMX: Fix wrong reserved bits of error-code
Date: Tue, 3 Sep 2019 10:23:32 -0700 [thread overview]
Message-ID: <20190903172332.GI10768@linux.intel.com> (raw)
In-Reply-To: <20190830204031.3100-3-namit@vmware.com>
On Fri, Aug 30, 2019 at 01:40:31PM -0700, Nadav Amit wrote:
> The SDM indeed says that "If deliver-error-code is 1, bits 31:15 of the
> VM-entry exception error-code field are 0." However, the SDM is wrong,
> and bits that need to be zeroed are 31:16.
>
> Our engineers confirmed that the SDM is wrong with Intel. Fix the test.
>
> Note that KVM should be fixed as well.
>
> Fixes: 8d2cdb35a07a ("x86: Add test for nested VM entry prereqs")
> Cc: Marc Orr <marcorr@google.com>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
next prev parent reply other threads:[~2019-09-03 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 20:40 [kvm-unit-tests PATCH 0/2] x86: nVMX: Bug fixes Nadav Amit
2019-08-30 20:40 ` [kvm-unit-tests PATCH 1/2] x86: nVMX: Do not use test_skip() when multiple tests are run Nadav Amit
2019-09-03 17:28 ` Sean Christopherson
2019-09-03 17:44 ` Nadav Amit
2019-09-03 17:50 ` Sean Christopherson
2019-08-30 20:40 ` [kvm-unit-tests PATCH 2/2] x86: nVMX: Fix wrong reserved bits of error-code Nadav Amit
2019-09-03 17:23 ` Sean Christopherson [this message]
2019-09-10 17:16 ` [kvm-unit-tests PATCH 0/2] x86: nVMX: Bug fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903172332.GI10768@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=namit@vmware.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.