All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements
Date: Tue, 3 Sep 2019 18:32:49 +0100	[thread overview]
Message-ID: <20190903173249.GL1131@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190903164732.14194-1-vvidic@valentin-vidic.from.hr>

On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> +			} else if (uni == 0xFFFF) {
>  				skip = TRUE;

While we are at it, could you get rid of that 'TRUE' macro?
Or added

#define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true

if you want to properly emphasize it...

  reply	other threads:[~2019-09-03 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 16:47 [PATCH] staging: exfat: cleanup braces for if/else statements Valentin Vidic
2019-09-03 17:32 ` Al Viro [this message]
2019-09-03 18:12   ` Valentin Vidić
2019-09-04  9:38     ` David Laight
2019-09-04 17:05       ` Valentin Vidić
2019-09-03 18:19   ` Greg Kroah-Hartman
2019-09-03 18:55     ` [PATCH] staging: exfat: drop local TRUE/FALSE defines Valentin Vidic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903173249.GL1131@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    --cc=vvidic@valentin-vidic.from.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.