From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 04 Sep 2019 12:57:04 +0000
Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
Message-Id: <20190904125704.GC3093@kadam>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20190904100329.GE7007@mwanda>
 <20190904115057.GC4811@pendragon.ideasonboard.com>
In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Mark Brown <broonie@kernel.org>, kernel-janitors@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, dri-devel@lists.freedesktop.org, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>

On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> >  error:
> > -	put_device(&lvds->backlight->dev);
> > +	if (lvds->backlight)
> > +		put_device(&lvds->backlight->dev);
> 
> How about simply
> 
> -	put_device(&lvds->backlight->dev);
> +	backlight_put(lvds->backlight);

Yeah.  That's cleaner.  I will resend.

regards,
dan carpenter

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
Date: Wed, 4 Sep 2019 15:57:04 +0300
Message-ID: <20190904125704.GC3093@kadam>
References: <20190904100329.GE7007@mwanda>
 <20190904115057.GC4811@pendragon.ideasonboard.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2EAC58966C
 for <dri-devel@lists.freedesktop.org>; Wed,  4 Sep 2019 12:57:25 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Mark Brown <broonie@kernel.org>, kernel-janitors@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, dri-devel@lists.freedesktop.org, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBTZXAgMDQsIDIwMTkgYXQgMDI6NTA6NTdQTSArMDMwMCwgTGF1cmVudCBQaW5jaGFy
dCB3cm90ZToKPiA+ICBlcnJvcjoKPiA+IC0JcHV0X2RldmljZSgmbHZkcy0+YmFja2xpZ2h0LT5k
ZXYpOwo+ID4gKwlpZiAobHZkcy0+YmFja2xpZ2h0KQo+ID4gKwkJcHV0X2RldmljZSgmbHZkcy0+
YmFja2xpZ2h0LT5kZXYpOwo+IAo+IEhvdyBhYm91dCBzaW1wbHkKPiAKPiAtCXB1dF9kZXZpY2Uo
Jmx2ZHMtPmJhY2tsaWdodC0+ZGV2KTsKPiArCWJhY2tsaWdodF9wdXQobHZkcy0+YmFja2xpZ2h0
KTsKClllYWguICBUaGF0J3MgY2xlYW5lci4gIEkgd2lsbCByZXNlbmQuCgpyZWdhcmRzLApkYW4g
Y2FycGVudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=