From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
linux-scsi@vger.kernel.org, Joe Perches <joe@perches.com>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
Date: Wed, 4 Sep 2019 20:23:37 +0300 [thread overview]
Message-ID: <20190904172337.GW2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190904160423.3865-1-sakari.ailus@linux.intel.com>
On Wed, Sep 04, 2019 at 07:04:23PM +0300, Sakari Ailus wrote:
> Convert the remaining %pf users to %ps to prepare for the removal of the
> old %pf conversion specifier support.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> index e7463d561f305..749286acdc173 100644
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
> @@ -6051,7 +6051,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
> list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
> if (filter(ndlp, param)) {
> lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
> - "3185 FIND node filter %pf DID "
> + "3185 FIND node filter %ps DID "
> "ndlp x%px did x%x flg x%x st x%x "
> "xri x%x type x%x rpi x%x\n",
> filter, ndlp, ndlp->nlp_DID,
> @@ -6062,7 +6062,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
> }
> }
> lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
> - "3186 FIND node filter %pf NOT FOUND.\n", filter);
> + "3186 FIND node filter %ps NOT FOUND.\n", filter);
> return NULL;
> }
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index bb5705267c395..2ff0879a95126 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -2712,7 +2712,7 @@ lpfc_sli_handle_mb_event(struct lpfc_hba *phba)
>
> /* Mailbox cmd <cmd> Cmpl <cmpl> */
> lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
> - "(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "
> + "(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %ps "
> "Data: x%x x%x x%x x%x x%x x%x x%x x%x x%x "
> "x%x x%x x%x\n",
> pmb->vport ? pmb->vport->vpi : 0,
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-04 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 16:04 [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps Sakari Ailus
2019-09-04 17:23 ` Andy Shevchenko [this message]
2019-09-04 20:22 ` James Smart
2019-09-07 20:27 ` Martin K. Petersen
2019-09-09 13:22 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904172337.GW2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=james.smart@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.