From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Convert ICL-style DSI to use phy
 namespace
Date: Thu, 5 Sep 2019 16:00:47 +0300
Message-ID: <20190905130047.GK7482@intel.com>
References: <20190905012037.7157-1-matthew.d.roper@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4F3C86E0C8
 for <intel-gfx@lists.freedesktop.org>; Thu,  5 Sep 2019 13:00:51 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190905012037.7157-1-matthew.d.roper@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBTZXAgMDQsIDIwMTkgYXQgMDY6MjA6MzdQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBJQ0wrIERTSSBvdXRwdXRzIG9wZXJhdGUgYSBiaXQgZGlmZmVyZW50bHkgdGhhbiBEUC9I
RE1JL2VEUCBhbmQgYXJlIG1vcmUKPiBjbG9zZWx5IHRpZWQgdG8gdGhlIFBIWSB0aGFuIHRvIHRo
ZSBEREkuICBTaW5jZSB3ZSd2ZSBzZXBhcmF0ZWQgUEhZJ3MKPiBvdXQgaW50byB0aGVpciBvd24g
bmFtZXNwYWNlIGl0IG1ha2VzIHNlbnNlIHRvIG9wZXJhdGUgb24gJ2VudW0gcGh5Jwo+IHRocm91
Z2hvdXQgbW9zdCBvZiB0aGUgSUNMIERTSSBjb2RlIHJhdGhlciB0aGFuICdlbnVtIHBvcnQnIHdo
aWNoIHdlCj4gZ2VuZXJhbGx5IHVzZSB0byByZWZlciB0byB0aGUgRERJIHRoZXNlIGRheXMuICBQ
YXJ0IG9mIHRoaXMgdHJhbnNpdGlvbgo+IGhhcyBhbHJlYWR5IGJlZW4gZG9uZSBhcyBwYXJ0IG9m
IGNvbW1pdCBkYzg2N2JjN2Q4ODcgKCJkcm0vaTkxNS9nZW4xMToKPiBDb252ZXJ0IGNvbWJvIFBI
WSBsb2dpYyB0byB1c2UgbmV3ICdlbnVtIHBoeScgbmFtZXNwYWNlIiksIGFsdGhvdWdoIHRoYXQK
PiBwYXRjaCBvbmx5IG1pZ3JhdGVkIHRoZSBwYXJ0cyBvZiB0aGUgY29kZSB0aGF0IHdlcmUgc3Bl
Y2lmaWNhbGx5Cj4gdXBkYXRpbmcgdGhlIGNvbWJvIFBIWSByZWdpc3RlcnMgdGhlbXNlbHZlcy4g
IE1vdmluZyB0aGUgcmVzdCBvZiB0aGUKPiBjb2RlIG92ZXIgdG8gdGhlIFBIWSBuYW1lc3BhY2Ug
YXMgd2VsbCB3aWxsIGhvcGVmdWxseSBtYWtlIHRoaW5ncyBtb3JlCj4gY29uc2lzdGVudCBhbmQg
bGVzcyBjb25mdXNpbmcuCj4gCj4gTm90ZSB0aGF0IHRoZSBjaGFuZ2UgaGVyZSBpcyByZWFsbHkg
anVzdCBhIG5hbWluZyBjaGFuZ2UuICBPbiBhbGwgb2YgdGhlCj4gcGxhdGZvcm1zIHRoYXQgdGhp
cyBjb2RlIGN1cnJlbnRseSBhcHBsaWVzIHRvLCB0aGUgRFNJIG91dHB1dHMgYWx3YXlzCj4gaGF2
ZSBwb3J0PT1waHkgc28gd2UncmUgc3RpbGwgcGFzc2luZyB0aGUgc2FtZSBpbnRlZ2VyIHZhbHVl
cyBhcm91bmQgbm8KPiBtYXR0ZXIgd2hpY2ggdHlwZSBvZiBlbnVtIHRoZXkgYmVsb25nIHRvLi4K
PiAKPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWdu
ZWQtb2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IC0tLQo+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ljbF9kc2kuYyAgIHwgMjM2ICsrKysrKysr
KysrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNp
LmggfCAgIDUgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMjYgaW5zZXJ0aW9ucygrKSwgMTE1IGRl
bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5
L2ljbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaWNsX2RzaS5jCj4gaW5k
ZXggNmUzOThjMzNhNTI0Li41Y2YzMjAzMmU3OTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvZGlzcGxheS9pY2xfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9k
aXNwbGF5L2ljbF9kc2kuYwo+IEBAIC02NSw5ICs2NSw5IEBAIHN0YXRpYyB2b2lkIHdhaXRfZm9y
X3BheWxvYWRfY3JlZGl0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJ
RFJNX0VSUk9SKCJEU0kgcGF5bG9hZCBjcmVkaXRzIG5vdCByZWxlYXNlZFxuIik7Cj4gIH0KPiAg
Cj4gLXN0YXRpYyBlbnVtIHRyYW5zY29kZXIgZHNpX3BvcnRfdG9fdHJhbnNjb2RlcihlbnVtIHBv
cnQgcG9ydCkKPiArc3RhdGljIGVudW0gdHJhbnNjb2RlciBkc2lfcGh5X3RvX3RyYW5zY29kZXIo
ZW51bSBwaHkgcGh5KQo+ICB7Cj4gLQlpZiAocG9ydCA9PSBQT1JUX0EpCj4gKwlpZiAocGh5ID09
IFBIWV9BKQo+ICAJCXJldHVybiBUUkFOU0NPREVSX0RTSV8wOwo+ICAJZWxzZQo+ICAJCXJldHVy
biBUUkFOU0NPREVSX0RTSV8xOwo+IEBAIC03OCwyMCArNzgsMjAgQEAgc3RhdGljIHZvaWQgd2Fp
dF9mb3JfY21kc19kaXNwYXRjaGVkX3RvX3BhbmVsKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv
ZGVyKQo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNv
ZGVyLT5iYXNlLmRldik7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSBlbmNfdG9f
aW50ZWxfZHNpKCZlbmNvZGVyLT5iYXNlKTsKPiAgCXN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRz
aTsKPiAtCWVudW0gcG9ydCBwb3J0Owo+ICsJZW51bSBwaHkgcGh5Owo+ICAJZW51bSB0cmFuc2Nv
ZGVyIGRzaV90cmFuczsKPiAgCWludCByZXQ7Cj4gIAo+ICAJLyogd2FpdCBmb3IgaGVhZGVyL3Bh
eWxvYWQgY3JlZGl0cyB0byBiZSByZWxlYXNlZCAqLwo+IC0JZm9yX2VhY2hfZHNpX3BvcnQocG9y
dCwgaW50ZWxfZHNpLT5wb3J0cykgewo+IC0JCWRzaV90cmFucyA9IGRzaV9wb3J0X3RvX3RyYW5z
Y29kZXIocG9ydCk7Cj4gKwlmb3JfZWFjaF9kc2lfcGh5KHBoeSwgaW50ZWxfZHNpLT5waHlzKSB7
Cj4gKwkJZHNpX3RyYW5zID0gZHNpX3BoeV90b190cmFuc2NvZGVyKHBoeSk7Cj4gIAkJd2FpdF9m
b3JfaGVhZGVyX2NyZWRpdHMoZGV2X3ByaXYsIGRzaV90cmFucyk7Cj4gIAkJd2FpdF9mb3JfcGF5
bG9hZF9jcmVkaXRzKGRldl9wcml2LCBkc2lfdHJhbnMpOwo+ICAJfQo+ICAKPiAgCS8qIHNlbmQg
bm9wIERDUyBjb21tYW5kICovCj4gLQlmb3JfZWFjaF9kc2lfcG9ydChwb3J0LCBpbnRlbF9kc2kt
PnBvcnRzKSB7Cj4gLQkJZHNpID0gaW50ZWxfZHNpLT5kc2lfaG9zdHNbcG9ydF0tPmRldmljZTsK
PiArCWZvcl9lYWNoX2RzaV9waHkocGh5LCBpbnRlbF9kc2ktPnBoeXMpIHsKPiArCQlkc2kgPSBp
bnRlbF9kc2ktPmRzaV9ob3N0c1twaHldLT5kZXZpY2U7Cj4gIAkJZHNpLT5tb2RlX2ZsYWdzIHw9
IE1JUElfRFNJX01PREVfTFBNOwo+ICAJCWRzaS0+Y2hhbm5lbCA9IDA7Cj4gIAkJcmV0ID0gbWlw
aV9kc2lfZGNzX25vcChkc2kpOwo+IEBAIC0xMDAsMTQgKzEwMCwxNCBAQCBzdGF0aWMgdm9pZCB3
YWl0X2Zvcl9jbWRzX2Rpc3BhdGNoZWRfdG9fcGFuZWwoc3RydWN0IGludGVsX2VuY29kZXIgKmVu
Y29kZXIpCj4gIAl9Cj4gIAo+ICAJLyogd2FpdCBmb3IgaGVhZGVyIGNyZWRpdHMgdG8gYmUgcmVs
ZWFzZWQgKi8KPiAtCWZvcl9lYWNoX2RzaV9wb3J0KHBvcnQsIGludGVsX2RzaS0+cG9ydHMpIHsK
PiAtCQlkc2lfdHJhbnMgPSBkc2lfcG9ydF90b190cmFuc2NvZGVyKHBvcnQpOwo+ICsJZm9yX2Vh
Y2hfZHNpX3BoeShwaHksIGludGVsX2RzaS0+cGh5cykgewo+ICsJCWRzaV90cmFucyA9IGRzaV9w
aHlfdG9fdHJhbnNjb2RlcihwaHkpOwo+ICAJCXdhaXRfZm9yX2hlYWRlcl9jcmVkaXRzKGRldl9w
cml2LCBkc2lfdHJhbnMpOwo+ICAJfQo+ICAKPiAgCS8qIHdhaXQgZm9yIExQIFRYIGluIHByb2dy
ZXNzIGJpdCB0byBiZSBjbGVhcmVkICovCj4gLQlmb3JfZWFjaF9kc2lfcG9ydChwb3J0LCBpbnRl
bF9kc2ktPnBvcnRzKSB7Cj4gLQkJZHNpX3RyYW5zID0gZHNpX3BvcnRfdG9fdHJhbnNjb2Rlcihw
b3J0KTsKPiArCWZvcl9lYWNoX2RzaV9waHkocGh5LCBpbnRlbF9kc2ktPnBoeXMpIHsKPiArCQlk
c2lfdHJhbnMgPSBkc2lfcGh5X3RvX3RyYW5zY29kZXIocGh5KTsKPiAgCQlpZiAod2FpdF9mb3Jf
dXMoIShJOTE1X1JFQUQoRFNJX0xQX01TRyhkc2lfdHJhbnMpKSAmCj4gIAkJCQkgIExQVFhfSU5f
UFJPR1JFU1MpLCAyMCkpCj4gIAkJCURSTV9FUlJPUigiTFBUWCBiaXQgbm90IGNsZWFyZWRcbiIp
Owo+IEBAIC0xMTksNyArMTE5LDcgQEAgc3RhdGljIGJvb2wgYWRkX3BheWxkX3RvX3F1ZXVlKHN0
cnVjdCBpbnRlbF9kc2lfaG9zdCAqaG9zdCwgY29uc3QgdTggKmRhdGEsCj4gIHsKPiAgCXN0cnVj
dCBpbnRlbF9kc2kgKmludGVsX2RzaSA9IGhvc3QtPmludGVsX2RzaTsKPiAgCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfZHNpLT5iYXNlLmJhc2UuZGV2
KTsKPiAtCWVudW0gdHJhbnNjb2RlciBkc2lfdHJhbnMgPSBkc2lfcG9ydF90b190cmFuc2NvZGVy
KGhvc3QtPnBvcnQpOwo+ICsJZW51bSB0cmFuc2NvZGVyIGRzaV90cmFucyA9IGRzaV9waHlfdG9f
dHJhbnNjb2Rlcihob3N0LT5waHkpOwo+ICAJaW50IGZyZWVfY3JlZGl0czsKPiAgCWludCBpLCBq
Owo+ICAKPiBAQCAtMTQ2LDcgKzE0Niw3IEBAIHN0YXRpYyBpbnQgZHNpX3NlbmRfcGt0X2hkcihz
dHJ1Y3QgaW50ZWxfZHNpX2hvc3QgKmhvc3QsCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9kc2kgKmlu
dGVsX2RzaSA9IGhvc3QtPmludGVsX2RzaTsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfZHNpLT5iYXNlLmJhc2UuZGV2KTsKPiAtCWVudW0gdHJh
bnNjb2RlciBkc2lfdHJhbnMgPSBkc2lfcG9ydF90b190cmFuc2NvZGVyKGhvc3QtPnBvcnQpOwo+
ICsJZW51bSB0cmFuc2NvZGVyIGRzaV90cmFucyA9IGRzaV9waHlfdG9fdHJhbnNjb2Rlcihob3N0
LT5waHkpOwo+ICAJdTMyIHRtcDsKPiAgCWludCBmcmVlX2NyZWRpdHM7Cj4gIAo+IEBAIC0zMDUs
NyArMzA1LDcgQEAgc3RhdGljIHZvaWQgZ2VuMTFfZHNpX3Byb2dyYW1fZXNjX2Nsa19kaXYoc3Ry
dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGlu
dGVsX2RzaSAqaW50ZWxfZHNpID0gZW5jX3RvX2ludGVsX2RzaSgmZW5jb2Rlci0+YmFzZSk7Cj4g
LQllbnVtIHBvcnQgcG9ydDsKPiArCWVudW0gcGh5IHBoeTsKPiAgCXUzMiBicHAgPSBtaXBpX2Rz
aV9waXhlbF9mb3JtYXRfdG9fYnBwKGludGVsX2RzaS0+cGl4ZWxfZm9ybWF0KTsKPiAgCXUzMiBh
ZmVfY2xrX2toejsgLyogOFggQ2xvY2sgKi8KPiAgCXUzMiBlc2NfY2xrX2Rpdl9tOwo+IEBAIC0z
MTUsMjkgKzMxNSwyOSBAQCBzdGF0aWMgdm9pZCBnZW4xMV9kc2lfcHJvZ3JhbV9lc2NfY2xrX2Rp
dihzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCj4gIAllc2NfY2xrX2Rpdl9tID0g
RElWX1JPVU5EX1VQKGFmZV9jbGtfa2h6LCBEU0lfTUFYX0VTQ19DTEspOwo+ICAKPiAtCWZvcl9l
YWNoX2RzaV9wb3J0KHBvcnQsIGludGVsX2RzaS0+cG9ydHMpIHsKPiAtCQlJOTE1X1dSSVRFKElD
TF9EU0lfRVNDX0NMS19ESVYocG9ydCksCj4gKwlmb3JfZWFjaF9kc2lfcGh5KHBoeSwgaW50ZWxf
ZHNpLT5waHlzKSB7Cj4gKwkJSTkxNV9XUklURShJQ0xfRFNJX0VTQ19DTEtfRElWKHBoeSksCj4g
IAkJCSAgIGVzY19jbGtfZGl2X20gJiBJQ0xfRVNDX0NMS19ESVZfTUFTSyk7Cj4gLQkJUE9TVElO
R19SRUFEKElDTF9EU0lfRVNDX0NMS19ESVYocG9ydCkpOwo+ICsJCVBPU1RJTkdfUkVBRChJQ0xf
RFNJX0VTQ19DTEtfRElWKHBoeSkpOwo+ICAJfQo+ICAKPiAtCWZvcl9lYWNoX2RzaV9wb3J0KHBv
cnQsIGludGVsX2RzaS0+cG9ydHMpIHsKPiAtCQlJOTE1X1dSSVRFKElDTF9EUEhZX0VTQ19DTEtf
RElWKHBvcnQpLAo+ICsJZm9yX2VhY2hfZHNpX3BoeShwaHksIGludGVsX2RzaS0+cGh5cykgewo+
ICsJCUk5MTVfV1JJVEUoSUNMX0RQSFlfRVNDX0NMS19ESVYocGh5KSwKPiAgCQkJICAgZXNjX2Ns
a19kaXZfbSAmIElDTF9FU0NfQ0xLX0RJVl9NQVNLKTsKPiAtCQlQT1NUSU5HX1JFQUQoSUNMX0RQ
SFlfRVNDX0NMS19ESVYocG9ydCkpOwo+ICsJCVBPU1RJTkdfUkVBRChJQ0xfRFBIWV9FU0NfQ0xL
X0RJVihwaHkpKTsKPiAgCX0KPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZ2V0X2RzaV9pb19wb3dl
cl9kb21haW5zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCSAgICAg
c3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpKQo+ICB7Cj4gLQllbnVtIHBvcnQgcG9ydDsKPiAr
CWVudW0gcGh5IHBoeTsKPiAgCj4gLQlmb3JfZWFjaF9kc2lfcG9ydChwb3J0LCBpbnRlbF9kc2kt
PnBvcnRzKSB7Cj4gLQkJV0FSTl9PTihpbnRlbF9kc2ktPmlvX3dha2VyZWZbcG9ydF0pOwo+IC0J
CWludGVsX2RzaS0+aW9fd2FrZXJlZltwb3J0XSA9Cj4gKwlmb3JfZWFjaF9kc2lfcGh5KHBoeSwg
aW50ZWxfZHNpLT5waHlzKSB7Cj4gKwkJV0FSTl9PTihpbnRlbF9kc2ktPmlvX3dha2VyZWZbcGh5
XSk7Cj4gKwkJaW50ZWxfZHNpLT5pb193YWtlcmVmW3BoeV0gPQo+ICAJCQlpbnRlbF9kaXNwbGF5
X3Bvd2VyX2dldChkZXZfcHJpdiwKPiAtCQkJCQkJcG9ydCA9PSBQT1JUX0EgPwo+ICsJCQkJCQlw
aHkgPT0gUEhZX0EgPwo+ICAJCQkJCQlQT1dFUl9ET01BSU5fUE9SVF9ERElfQV9JTyA6Cj4gIAkJ
CQkJCVBPV0VSX0RPTUFJTl9QT1JUX0RESV9CX0lPKTsKCkkgdGhpbmsgdGhpcyBpcyBub3cgZ2V0
dGluZyBhIGJpdCBjb25mdXNpbmcgdy5yLnQuIHRoZSBub3JtYWwgRERJIGNvZGUuCldpdGggbm9y
bWFsIERESSBUaGUgSU8gcG93ZXIgcmVxdWVzdCBpcyBiYXNlZCBvbiB0aGUgRERJIG5vdCB0aGUg
UEhZLAphbmQgdGhlIHNhbWUgZ29lcyBmb3Igc3R1ZmYgbGlrZSBERElfQlVGX0NUTCBiZWxvdy4g
SU1PIHdvdWxkIGJlIG5pY2UKaWYgd2UgY291bGQga2VlcCB0aGVzZSB0aGluZ3MgY29uc2lzdGVu
dCBiZXR3ZWVuIHRoZSB0d28gcGF0aHMuCgpBcyBmb3IgdGhlIERTSSBzcGVjaWZpYyByZWdpc3Rl
cnMvZXRjLiBJJ20gbm90IHN1cmUgaWYgcG9ydCBvciBwaHkgd291bGQKYmUgbW9yZSBhcHByb3By
aWF0ZS4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4