From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 05 Sep 2019 14:52:48 +0000 Subject: Re: [PATCH] staging: rtl8723bs: hal: remove redundant assignment to variable n Message-Id: <20190905143341.GC3115@kadam> List-Id: References: <20190905141555.31582-1-colin.king@canonical.com> In-Reply-To: <20190905141555.31582-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org It would be better to remove "n" altogether. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467BDC43331 for ; Thu, 5 Sep 2019 14:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 867A4206CD for ; Thu, 5 Sep 2019 14:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="i4UQhfVp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390108AbfIEOxI (ORCPT ); Thu, 5 Sep 2019 10:53:08 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34256 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728258AbfIEOxH (ORCPT ); Thu, 5 Sep 2019 10:53:07 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x85EmkgT038129; Thu, 5 Sep 2019 14:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=9p3RFEoKFmUrFPVKoyVHtC/imV/dMJgGKCGFehzqd5w=; b=i4UQhfVpKAiH+xP+wop/DYSPkcTDYEWVcUd+lvZ0Uw/+UzbwN8cFG1R92Oa02T02gihW vc8qI3xXRQUrqqsAe7lGNDtdeta6GPt+9isZGjB89QsnG+IZ1k9o1N+1loRJLHC/Q6FB Hm1yiOIuYnvcWYyJc88c1aSEAKDWQQ9Vd6UtVKWrOdx7MdKiCK7EHz8cm9GQsLPxMNyD w4rlgQIAW8MaRZ8IXNiZZKG9np4JsC8MqNE0Yo8KcRUiPZCme4GHGOsOOsnhEeYuOloG yPm7gSm6uUpx2DZ8cPbeqmv1LIMdOvsJcxZD3bYb3ppotggv1lyd99otEIxEfafoUhb5 3w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2uu418886j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Sep 2019 14:53:02 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x85EmFgC145207; Thu, 5 Sep 2019 14:53:01 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2utvr3qaes-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Sep 2019 14:53:01 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x85EqwSZ013447; Thu, 5 Sep 2019 14:53:00 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Sep 2019 07:52:58 -0700 Date: Thu, 5 Sep 2019 17:52:48 +0300 From: Dan Carpenter To: Colin King Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: hal: remove redundant assignment to variable n Message-ID: <20190905143341.GC3115@kadam> References: <20190905141555.31582-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905141555.31582-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9370 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=981 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909050143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9370 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909050143 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It would be better to remove "n" altogether. regards, dan carpenter