All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Christopher S Hall <christopher.s.hall@intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH v2 2/2] PTP: add support for one-shot output
Date: Thu, 5 Sep 2019 22:35:56 -0700	[thread overview]
Message-ID: <20190906053556.GB1422@localhost> (raw)
In-Reply-To: <87h85roy9p.fsf@gmail.com>

On Thu, Sep 05, 2019 at 01:03:46PM +0300, Felipe Balbi wrote:
> This a bit confusing, really. Specially when the comment right above
> those flags states:
> 
> /* PTP_xxx bits, for the flags field within the request structures. */

Agreed, it is confusing.  Go ahead and remove this comment.

> Seems like we will, at least, make it clear which flags are valid for
> which request structures.

Yes, please do make it as clear as you can.

Thanks,
Richard

  reply	other threads:[~2019-09-06  5:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29  9:58 [PATCH v2 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-08-29  9:58 ` [PATCH v2 2/2] PTP: add support for one-shot output Felipe Balbi
2019-08-29 17:25   ` Richard Cochran
2019-08-29 17:28     ` Richard Cochran
2019-08-30  8:00       ` Felipe Balbi
2019-08-31 14:47         ` Richard Cochran
2019-09-05 10:03           ` Felipe Balbi
2019-09-06  5:35             ` Richard Cochran [this message]
2019-08-31 15:01         ` Richard Cochran
2019-09-05 10:40           ` Felipe Balbi
2019-08-29 17:21 ` [PATCH v2 1/2] PTP: introduce new versions of IOCTLs Richard Cochran
2019-08-30  7:57   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906053556.GB1422@localhost \
    --to=richardcochran@gmail.com \
    --cc=christopher.s.hall@intel.com \
    --cc=davem@davemloft.net \
    --cc=felipe.balbi@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.