From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Elkouby <streetwalkermc@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Fabian Henneke <fabian.henneke@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report
Date: Fri, 6 Sep 2019 13:58:24 +0300 [thread overview]
Message-ID: <20190906105824.GA14147@kadam> (raw)
In-Reply-To: <CANnEQ3HX0SNG+Hzs2b+BzLwuewsC8-3sF2urWV+bqUahXq0hVA@mail.gmail.com>
On Fri, Sep 06, 2019 at 01:40:15PM +0300, Dan Elkouby wrote:
> On Fri, Sep 6, 2019 at 1:14 PM Dan Carpenter wrote:
> > I think we also need to update update ms_ff_worker() which assumes that
> > hid_hw_output_report() returns zero on success.
>
> Yes, it looks like that's the case. Should I amend my patch to include
> this fix, or should it be a separate patch? I don't have access to any
> hardware covered by hid-microsoft, so I won't be able to test it.
>
Yes. Please amend the patch. We all understand that you don't have
the hardware so it's not a problem. If you want to blame me in the
commit message that's fine. "Dan Carpenter pointed out a related issue
in ms_ff_worker()". But we're only silencing a warning so it can't
really break anything.
You can add my Reviewed-by tag as well when you resend.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-06 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 9:41 [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Dan Elkouby
2019-09-06 10:13 ` Dan Carpenter
2019-09-06 10:40 ` Dan Elkouby
2019-09-06 10:58 ` Dan Carpenter [this message]
2019-09-06 11:06 ` [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message Dan Elkouby
2019-09-06 11:11 ` Dan Carpenter
2019-09-06 11:31 ` Jiri Kosina
2019-09-06 13:57 ` Marcel Holtmann
2019-09-23 20:33 ` Andrey Smirnov
2019-09-06 13:56 ` [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Marcel Holtmann
2019-09-06 14:05 ` Dan Elkouby
2019-09-06 14:08 ` Dan Carpenter
2019-09-06 14:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906105824.GA14147@kadam \
--to=dan.carpenter@oracle.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=computersforpeace@gmail.com \
--cc=davem@davemloft.net \
--cc=fabian.henneke@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=streetwalkermc@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.