* [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency
@ 2019-09-05 18:13 Matt Roper
2019-09-05 18:54 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Matt Roper @ 2019-09-05 18:13 UTC (permalink / raw)
To: intel-gfx
Unlike gen11, which always ran at 50MHz when the cdclk PLL was disabled,
TGL runs at refclk/2. The 50MHz croclk/2 is only used by hardware
during some power state transitions.
Bspec: 49201
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 76f11d465e91..d3e56628af70 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1855,8 +1855,6 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv,
u32 val;
int div;
- cdclk_state->bypass = 50000;
-
val = I915_READ(SKL_DSSM);
switch (val & ICL_DSSM_CDCLK_PLL_REFCLK_MASK) {
default:
@@ -1873,6 +1871,11 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv,
break;
}
+ if (INTEL_GEN(dev_priv) >= 12)
+ cdclk_state->bypass = cdclk_state->ref / 2;
+ else
+ cdclk_state->bypass = 50000;
+
val = I915_READ(BXT_DE_PLL_ENABLE);
if ((val & BXT_DE_PLL_PLL_ENABLE) == 0 ||
(val & BXT_DE_PLL_LOCK) == 0) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/tgl: Use refclk/2 as bypass frequency 2019-09-05 18:13 [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency Matt Roper @ 2019-09-05 18:54 ` Patchwork 2019-09-05 23:07 ` ✓ Fi.CI.IGT: " Patchwork 2019-09-06 11:36 ` [PATCH] " Ville Syrjälä 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-09-05 18:54 UTC (permalink / raw) To: Matt Roper; +Cc: intel-gfx == Series Details == Series: drm/i915/tgl: Use refclk/2 as bypass frequency URL : https://patchwork.freedesktop.org/series/66293/ State : success == Summary == CI Bug Log - changes from CI_DRM_6839 -> Patchwork_14291 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/ Known issues ------------ Here are the changes found in Patchwork_14291 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_reloc@basic-gtt-cpu: - fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-skl-6770hq/igt@gem_exec_reloc@basic-gtt-cpu.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-skl-6770hq/igt@gem_exec_reloc@basic-gtt-cpu.html * igt@gem_exec_suspend@basic-s4-devices: - fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_chamelium@dp-edid-read: - fi-icl-u2: [PASS][5] -> [FAIL][6] ([fdo#109483] / [fdo#109635 ]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html #### Possible fixes #### * igt@gem_ctx_create@basic-files: - fi-icl-u3: [INCOMPLETE][7] ([fdo#107713] / [fdo#109100]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-icl-u3/igt@gem_ctx_create@basic-files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-icl-u3/igt@gem_ctx_create@basic-files.html * igt@i915_selftest@live_requests: - {fi-icl-guc}: [INCOMPLETE][9] ([fdo#107713] / [fdo#109644] / [fdo#110464]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-icl-guc/igt@i915_selftest@live_requests.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-icl-guc/igt@i915_selftest@live_requests.html * igt@kms_busy@basic-flip-c: - fi-skl-6770hq: [SKIP][11] ([fdo#109271] / [fdo#109278]) -> [PASS][12] +2 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html * igt@kms_flip@basic-flip-vs-dpms: - fi-skl-6770hq: [SKIP][13] ([fdo#109271]) -> [PASS][14] +23 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u2: [FAIL][15] ([fdo#103167]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 [fdo#109644]: https://bugs.freedesktop.org/show_bug.cgi?id=109644 [fdo#110464]: https://bugs.freedesktop.org/show_bug.cgi?id=110464 Participating hosts (55 -> 46) ------------------------------ Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y fi-byt-clapper fi-bdw-samus fi-kbl-r Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6839 -> Patchwork_14291 CI-20190529: 20190529 CI_DRM_6839: d3d45e02f5adaa9b9dae212460b3d93cc6e28a4b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5171: 1911564805fe454919e8a5846534a0c1ef376a33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14291: 72a3349eb06b6cbbdde502c014366f14cce7cd5d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 72a3349eb06b drm/i915/tgl: Use refclk/2 as bypass frequency == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/tgl: Use refclk/2 as bypass frequency 2019-09-05 18:13 [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency Matt Roper 2019-09-05 18:54 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-09-05 23:07 ` Patchwork 2019-09-06 11:36 ` [PATCH] " Ville Syrjälä 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-09-05 23:07 UTC (permalink / raw) To: Matt Roper; +Cc: intel-gfx == Series Details == Series: drm/i915/tgl: Use refclk/2 as bypass frequency URL : https://patchwork.freedesktop.org/series/66293/ State : success == Summary == CI Bug Log - changes from CI_DRM_6839_full -> Patchwork_14291_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_14291_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@reset-stress: - shard-glk: [PASS][1] -> [FAIL][2] ([fdo#109661]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-glk3/igt@gem_eio@reset-stress.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-glk7/igt@gem_eio@reset-stress.html - shard-kbl: [PASS][3] -> [FAIL][4] ([fdo#109661]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-kbl1/igt@gem_eio@reset-stress.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-kbl6/igt@gem_eio@reset-stress.html * igt@gem_exec_schedule@pi-ringfull-vebox: - shard-apl: [PASS][5] -> [FAIL][6] ([fdo#111547]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl8/igt@gem_exec_schedule@pi-ringfull-vebox.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl2/igt@gem_exec_schedule@pi-ringfull-vebox.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +7 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_request_retire@retire-vma-not-inactive: - shard-apl: [PASS][9] -> [INCOMPLETE][10] ([fdo#103927]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl4/igt@gem_request_retire@retire-vma-not-inactive.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl8/igt@gem_request_retire@retire-vma-not-inactive.html * igt@gem_workarounds@suspend-resume-context: - shard-kbl: [PASS][11] -> [INCOMPLETE][12] ([fdo#103665]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-kbl6/igt@gem_workarounds@suspend-resume-context.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-kbl4/igt@gem_workarounds@suspend-resume-context.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-kbl: [PASS][13] -> [SKIP][14] ([fdo#109271]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-apl: [PASS][15] -> [FAIL][16] ([fdo#103375]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl4/igt@i915_pm_rpm@system-suspend-modeset.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl2/igt@i915_pm_rpm@system-suspend-modeset.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl7/igt@i915_suspend@sysfs-reader.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl1/igt@i915_suspend@sysfs-reader.html * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-glk6/igt@kms_flip@flip-vs-expired-vblank.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-glk2/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#105363]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt: - shard-skl: [PASS][23] -> [FAIL][24] ([fdo#103167]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-skl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-skl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +6 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-snb: [PASS][27] -> [FAIL][28] ([fdo#103375]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-snb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-snb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb5/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf_pmu@enable-race-vecs0: - shard-apl: [PASS][35] -> [FAIL][36] ([fdo#111545]) +12 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl8/igt@perf_pmu@enable-race-vecs0.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl2/igt@perf_pmu@enable-race-vecs0.html * igt@prime_busy@after-bsd2: - shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +15 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb2/igt@prime_busy@after-bsd2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb5/igt@prime_busy@after-bsd2.html #### Possible fixes #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][39] ([fdo#110841]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_balancer@bonded-imm: - shard-apl: [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl8/igt@gem_exec_balancer@bonded-imm.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl7/igt@gem_exec_balancer@bonded-imm.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][43] ([fdo#110854]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb6/igt@gem_exec_balancer@smoke.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb1/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][45] ([fdo#111325]) -> [PASS][46] +6 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@gem_exec_suspend@basic-s4-devices: - shard-hsw: [FAIL][47] ([fdo#111550]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-hsw7/igt@gem_exec_suspend@basic-s4-devices.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-hsw7/igt@gem_exec_suspend@basic-s4-devices.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +2 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl5/igt@gem_workarounds@suspend-resume-context.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl6/igt@gem_workarounds@suspend-resume-context.html * igt@i915_pm_rpm@pm-tiling: - shard-hsw: [FAIL][51] ([fdo#111548]) -> [PASS][52] +4 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-hsw7/igt@i915_pm_rpm@pm-tiling.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-hsw6/igt@i915_pm_rpm@pm-tiling.html * igt@i915_selftest@mock_fence: - shard-iclb: [INCOMPLETE][53] ([fdo#107713]) -> [PASS][54] +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb1/igt@i915_selftest@mock_fence.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb1/igt@i915_selftest@mock_fence.html * igt@i915_suspend@forcewake: - shard-snb: [FAIL][55] ([fdo#103375]) -> [PASS][56] +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-snb5/igt@i915_suspend@forcewake.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-snb6/igt@i915_suspend@forcewake.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [FAIL][57] ([fdo#103375]) -> [PASS][58] +3 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [FAIL][59] ([fdo#103167]) -> [PASS][60] +6 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-hsw: [FAIL][61] ([fdo#103375]) -> [PASS][62] +4 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-hsw7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-hsw2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb8/igt@kms_psr2_su@page_flip.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@perf_pmu@rc6: - shard-apl: [FAIL][67] ([fdo#111545]) -> [PASS][68] +9 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl3/igt@perf_pmu@rc6.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl4/igt@perf_pmu@rc6.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][69] ([fdo#109276]) -> [PASS][70] +22 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb6/igt@prime_busy@hang-bsd2.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb1/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][71] ([fdo#111329]) -> [SKIP][72] ([fdo#109276]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_mocs_settings@mocs-settings-bsd2: - shard-iclb: [SKIP][73] ([fdo#109276]) -> [FAIL][74] ([fdo#111330]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-iclb3/igt@gem_mocs_settings@mocs-settings-bsd2.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html * igt@i915_pm_rpm@modeset-lpsp: - shard-hsw: [FAIL][75] ([fdo#111548]) -> [SKIP][76] ([fdo#109271]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-hsw7/igt@i915_pm_rpm@modeset-lpsp.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-hsw1/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [FAIL][77] ([fdo#103375]) -> [DMESG-WARN][78] ([fdo#108566]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@perf_pmu@cpu-hotplug: - shard-hsw: [TIMEOUT][79] ([fdo#111546]) -> [INCOMPLETE][80] ([fdo#103540]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6839/shard-hsw7/igt@perf_pmu@cpu-hotplug.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/shard-hsw6/igt@perf_pmu@cpu-hotplug.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#111545]: https://bugs.freedesktop.org/show_bug.cgi?id=111545 [fdo#111546]: https://bugs.freedesktop.org/show_bug.cgi?id=111546 [fdo#111547]: https://bugs.freedesktop.org/show_bug.cgi?id=111547 [fdo#111548]: https://bugs.freedesktop.org/show_bug.cgi?id=111548 [fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6839 -> Patchwork_14291 CI-20190529: 20190529 CI_DRM_6839: d3d45e02f5adaa9b9dae212460b3d93cc6e28a4b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5171: 1911564805fe454919e8a5846534a0c1ef376a33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14291: 72a3349eb06b6cbbdde502c014366f14cce7cd5d @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14291/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency 2019-09-05 18:13 [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency Matt Roper 2019-09-05 18:54 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-05 23:07 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-09-06 11:36 ` Ville Syrjälä 2019-09-06 15:45 ` Matt Roper 2 siblings, 1 reply; 5+ messages in thread From: Ville Syrjälä @ 2019-09-06 11:36 UTC (permalink / raw) To: Matt Roper; +Cc: intel-gfx On Thu, Sep 05, 2019 at 11:13:37AM -0700, Matt Roper wrote: > Unlike gen11, which always ran at 50MHz when the cdclk PLL was disabled, > TGL runs at refclk/2. The 50MHz croclk/2 is only used by hardware > during some power state transitions. > > Bspec: 49201 > Cc: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 76f11d465e91..d3e56628af70 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -1855,8 +1855,6 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv, > u32 val; > int div; > > - cdclk_state->bypass = 50000; > - > val = I915_READ(SKL_DSSM); > switch (val & ICL_DSSM_CDCLK_PLL_REFCLK_MASK) { > default: > @@ -1873,6 +1871,11 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv, > break; > } > > + if (INTEL_GEN(dev_priv) >= 12) > + cdclk_state->bypass = cdclk_state->ref / 2; > + else > + cdclk_state->bypass = 50000; Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> PS. I'd still like to see a icl_cdclk_pll_update() so I wouldn't have to scratch my head why this looks so different to bxt/cnl code. > + > val = I915_READ(BXT_DE_PLL_ENABLE); > if ((val & BXT_DE_PLL_PLL_ENABLE) == 0 || > (val & BXT_DE_PLL_LOCK) == 0) { > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency 2019-09-06 11:36 ` [PATCH] " Ville Syrjälä @ 2019-09-06 15:45 ` Matt Roper 0 siblings, 0 replies; 5+ messages in thread From: Matt Roper @ 2019-09-06 15:45 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx On Fri, Sep 06, 2019 at 02:36:49PM +0300, Ville Syrjälä wrote: > On Thu, Sep 05, 2019 at 11:13:37AM -0700, Matt Roper wrote: > > Unlike gen11, which always ran at 50MHz when the cdclk PLL was disabled, > > TGL runs at refclk/2. The 50MHz croclk/2 is only used by hardware > > during some power state transitions. > > > > Bspec: 49201 > > Cc: José Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > > index 76f11d465e91..d3e56628af70 100644 > > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > > @@ -1855,8 +1855,6 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv, > > u32 val; > > int div; > > > > - cdclk_state->bypass = 50000; > > - > > val = I915_READ(SKL_DSSM); > > switch (val & ICL_DSSM_CDCLK_PLL_REFCLK_MASK) { > > default: > > @@ -1873,6 +1871,11 @@ static void icl_get_cdclk(struct drm_i915_private *dev_priv, > > break; > > } > > > > + if (INTEL_GEN(dev_priv) >= 12) > > + cdclk_state->bypass = cdclk_state->ref / 2; > > + else > > + cdclk_state->bypass = 50000; > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > PS. I'd still like to see a icl_cdclk_pll_update() so I wouldn't have to > scratch my head why this looks so different to bxt/cnl code. Applied to dinq; thanks for the review. As you mentioned, I'll look into further updates to the ICL-style cdclk code to bring it more in line with other platforms. Matt > > > + > > val = I915_READ(BXT_DE_PLL_ENABLE); > > if ((val & BXT_DE_PLL_PLL_ENABLE) == 0 || > > (val & BXT_DE_PLL_LOCK) == 0) { > > -- > > 2.20.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-06 15:45 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-05 18:13 [PATCH] drm/i915/tgl: Use refclk/2 as bypass frequency Matt Roper 2019-09-05 18:54 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-05 23:07 ` ✓ Fi.CI.IGT: " Patchwork 2019-09-06 11:36 ` [PATCH] " Ville Syrjälä 2019-09-06 15:45 ` Matt Roper
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.