From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Fri, 06 Sep 2019 14:11:53 +0000 Subject: Re: [PATCH] rtlwifi: Fix file release memory leak Message-Id: <20190906141153.CF5606118D@smtp.codeaurora.org> List-Id: References: <20190904141611.4780-1-weiyongjun1@huawei.com> In-Reply-To: <20190904141611.4780-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Wei Yongjun wrote: > When using single_open() for opening, single_release() should be > used instead of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") > Signed-off-by: Wei Yongjun Patch applied to wireless-drivers-next.git, thanks. 4c3e48794dec rtlwifi: Fix file release memory leak -- https://patchwork.kernel.org/patch/11130357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E22C43331 for ; Fri, 6 Sep 2019 14:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96B0120854 for ; Fri, 6 Sep 2019 14:11:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="HJLSFNKP"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cYuShNFD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404595AbfIFOLz (ORCPT ); Fri, 6 Sep 2019 10:11:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46738 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731109AbfIFOLy (ORCPT ); Fri, 6 Sep 2019 10:11:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CF5606118D; Fri, 6 Sep 2019 14:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779113; bh=87O41lyZfEnUjjdEeuKeDT+ml8txqow14NjWrIcm7qw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=HJLSFNKPdmvw04PKT7kHon9Y8doTz5Hq188H5U8Ks61nGyl+bNixDY1vd8YXXWXdt 9zIha18A5/8Q5QEOtfcx4zOw5dz957c9pmq15Mmj12aL2Wzyn8RcworXW11kchrTwC 69DASwnhgmgvcD2pkWetU2mss8CXnZ/2uossVBcg= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2651D6030B; Fri, 6 Sep 2019 14:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779113; bh=87O41lyZfEnUjjdEeuKeDT+ml8txqow14NjWrIcm7qw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=cYuShNFDgyOE4CfRJJK9cR7fjS1j8XJ/Wy/F9Z2fpl/bPY9MaTAADQIJKS3AHGvV8 VxliY0v8PGyJ+BeDj2kDity11tLVMBCZSjzLoKktGE32inYfLB3DTD3hd330hutVV3 L/ya+yadH3feCK/xoFY50hQnbkFCtEfzzauuHJ9M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2651D6030B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: Fix file release memory leak From: Kalle Valo In-Reply-To: <20190904141611.4780-1-weiyongjun1@huawei.com> References: <20190904141611.4780-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: Ping-Ke Shih , Wei Yongjun , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190906141153.CF5606118D@smtp.codeaurora.org> Date: Fri, 6 Sep 2019 14:11:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wei Yongjun wrote: > When using single_open() for opening, single_release() should be > used instead of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") > Signed-off-by: Wei Yongjun Patch applied to wireless-drivers-next.git, thanks. 4c3e48794dec rtlwifi: Fix file release memory leak -- https://patchwork.kernel.org/patch/11130357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches