From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
devel@driverdev.osuosl.org,
Valentin Vidic <vvidic@valentin-vidic.from.hr>,
linux-kernel@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH 1/2] exfat stopusing CONFIG_FAT_DEFAULT_IOCHARSET
Date: Fri, 6 Sep 2019 18:18:57 +0200 [thread overview]
Message-ID: <20190906161857.GA2585@kroah.com> (raw)
In-Reply-To: <20190906150917.1025250-1-arnd@arndb.de>
On Fri, Sep 06, 2019 at 05:09:04PM +0200, Arnd Bergmann wrote:
> When CONFIG_VFAT_FS is disabled, the reference to CONFIG_FAT_DEFAULT_IOCHARSET
> causes a link failure:
>
> drivers/staging/exfat/exfat_super.c:46:41: error: use of undeclared identifier 'CONFIG_FAT_DEFAULT_IOCHARSET'
> static char exfat_default_iocharset[] = CONFIG_FAT_DEFAULT_IOCHARSET;
>
> I could not figure out why the correct code is commented
> out, but using that fixes the problem.
For some reason I was getting a build error without that, I added those
commented out lines. Odd. Oh well, thanks for fixing this :)
greg k-h
prev parent reply other threads:[~2019-09-06 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:09 [PATCH 1/2] exfat stopusing CONFIG_FAT_DEFAULT_IOCHARSET Arnd Bergmann
2019-09-06 15:09 ` [PATCH 2/2] exfat: stop using 32-bit time_t Arnd Bergmann
2019-09-06 16:18 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906161857.GA2585@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.