From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F133C43331 for ; Fri, 6 Sep 2019 17:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06337214DE for ; Fri, 6 Sep 2019 17:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567790877; bh=aLRmPl43ZbLFE5HkFDGotmTtNfpnGumo9iTQkZUEWHA=; h=In-Reply-To:References:To:From:Cc:Subject:Date:List-ID:From; b=fYmMqIJO5XBcKavpvkohrzsnx2xrJg8TXHc2+nFMMgOOuakdj9tlFK+k1qWl7fqFR Q/DkzRaxbk4MSfnWewzALfe5ub+VYRC4cD8Zt7dRBxavinMrz1rl1QFvfzL+5gJG4F GTfP0qh+dK2DY4POqvmGThic3bvEATNHwdlBBSEY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388626AbfIFR14 (ORCPT ); Fri, 6 Sep 2019 13:27:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:37208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731974AbfIFR14 (ORCPT ); Fri, 6 Sep 2019 13:27:56 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0146020838; Fri, 6 Sep 2019 17:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567790876; bh=aLRmPl43ZbLFE5HkFDGotmTtNfpnGumo9iTQkZUEWHA=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=NXeAVOXDmbDAR6b8gVPBLnnahqfeZNg6ihO6nSKugJCoA53yiqFcfp+s+i98IaPGi FQuPIhtsTzbFZDerXuHHCUXk/+NUCuy+VNGEpNE59Ms9FXLGFAECSNE2elu0DUAkwG geVPM/by/joxsfKwQGQgNW8B+DkbdVN48mt/wzSI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190813085714.8079-1-nishkadg.linux@gmail.com> References: <20190813085714.8079-1-nishkadg.linux@gmail.com> To: Nishka Dasgupta , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, vireshk@kernel.org From: Stephen Boyd Cc: Nishka Dasgupta Subject: Re: [PATCH] clk: spear: Make structure i2s_sclk_masks constant User-Agent: alot/0.8.1 Date: Fri, 06 Sep 2019 10:27:55 -0700 Message-Id: <20190906172756.0146020838@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Nishka Dasgupta (2019-08-13 01:57:14) > Static structure i2s_sclk_masks, having type aux_clk_masks, is only used > when it is passed as the sixth argument to function clk_register_aux(). > However, clk_register_aux() is defined with its sixth argument as const. > Hence i2s_sclk_masks is not modified by clk_register_aux, which is also > the only usage of the former. Therefore make i2s_sclk_masks constant as > it is never modified. > Issue found with Coccinelle. >=20 > Signed-off-by: Nishka Dasgupta > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F69C43331 for ; Fri, 6 Sep 2019 17:28:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B78C20842 for ; Fri, 6 Sep 2019 17:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="utPZKJN/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NXeAVOXD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B78C20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B3kKCYqUQ2Q5N2ufY4SV+XYc3mxKr4iC1zS79GNgRaI=; b=utPZKJN/rRH7x3 NLQIUzC2Vzfs3HL68zAMNoRL7iJEzpV3t8xxLGBnvqPJKvMdfbf9ycK7+Pd12Un3ILmdn0jQq3+Vp 0MFN6EWZUXe9Rj5F5VhaXNzeauk9sQF9Qu7MNR1CfdXGGNHnTmIdliTV0oVvouD/nR0Cl/gx+8WlK pZNC4CwYbtYUMuNNIC+9HVF1xR0LxRD1MVMnmN9cRhr3v/1V1MF6COkj+obElA5reybvHvg6kNh4W UDUW/QQya7iiPGcFeoHgsRtAASGrHX/BKeMxMkrz+NHK0/lqKeRXwgWbYzNadsUNivk0rABIWmrNo zusJDoAV93hWIB2tW+gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6I1f-0001og-Kf; Fri, 06 Sep 2019 17:27:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i6I1c-0001oP-Eo for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2019 17:27:57 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0146020838; Fri, 6 Sep 2019 17:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567790876; bh=aLRmPl43ZbLFE5HkFDGotmTtNfpnGumo9iTQkZUEWHA=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=NXeAVOXDmbDAR6b8gVPBLnnahqfeZNg6ihO6nSKugJCoA53yiqFcfp+s+i98IaPGi FQuPIhtsTzbFZDerXuHHCUXk/+NUCuy+VNGEpNE59Ms9FXLGFAECSNE2elu0DUAkwG geVPM/by/joxsfKwQGQgNW8B+DkbdVN48mt/wzSI= MIME-Version: 1.0 In-Reply-To: <20190813085714.8079-1-nishkadg.linux@gmail.com> References: <20190813085714.8079-1-nishkadg.linux@gmail.com> To: Nishka Dasgupta , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, vireshk@kernel.org From: Stephen Boyd Subject: Re: [PATCH] clk: spear: Make structure i2s_sclk_masks constant User-Agent: alot/0.8.1 Date: Fri, 06 Sep 2019 10:27:55 -0700 Message-Id: <20190906172756.0146020838@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_102756_522051_01CDE1C4 X-CRM114-Status: UNSURE ( 7.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishka Dasgupta Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nishka Dasgupta (2019-08-13 01:57:14) > Static structure i2s_sclk_masks, having type aux_clk_masks, is only used > when it is passed as the sixth argument to function clk_register_aux(). > However, clk_register_aux() is defined with its sixth argument as const. > Hence i2s_sclk_masks is not modified by clk_register_aux, which is also > the only usage of the former. Therefore make i2s_sclk_masks constant as > it is never modified. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel