From: Shmulik Ladkani <shmulik@metanetworks.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
eyal@metanetworks.com, netdev <netdev@vger.kernel.org>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: Re: [PATCH net] net: gso: Fix skb_segment splat when splitting gso_size mangled skb having linear-headed frag_list
Date: Fri, 6 Sep 2019 18:37:07 +0300 [thread overview]
Message-ID: <20190906183707.3eaacd79@pixies> (raw)
In-Reply-To: <CAF=yD-JB6TMQuyaxzLX8=9CZZF+Zk5EmniSkx_F81bVc87XqJw@mail.gmail.com>
On Fri, 6 Sep 2019 10:49:55 -0400
Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> But I wonder whether it is a given that head_skb has headlen.
This is what I observed for GRO packets that do have headlen frag_list
members: the 'head_skb' itself had a headlen too, and its head was
built using the original gso_size (similar to the frag_list members).
Maybe Eric can comment better.
> Btw, it seems slightly odd to me tot test head_frag before testing
> headlen in the v2 patch.
Requested by Alexander. I'm fine either way.
Thanks
Shmulik
next prev parent reply other threads:[~2019-09-06 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 18:36 [PATCH net] net: gso: Fix skb_segment splat when splitting gso_size mangled skb having linear-headed frag_list Shmulik Ladkani
2019-09-05 21:49 ` Alexander Duyck
2019-09-06 6:20 ` Shmulik Ladkani
2019-09-05 21:51 ` Willem de Bruijn
2019-09-06 6:47 ` Shmulik Ladkani
2019-09-06 14:49 ` Willem de Bruijn
2019-09-06 15:37 ` Shmulik Ladkani [this message]
2019-09-06 15:42 ` Alexander Duyck
2019-09-06 16:44 ` Willem de Bruijn
2019-09-06 20:02 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906183707.3eaacd79@pixies \
--to=shmulik@metanetworks.com \
--cc=alexander.duyck@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=eyal@metanetworks.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.