All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-pip: bump to version 19.2.3
Date: Fri, 6 Sep 2019 21:40:37 +0200	[thread overview]
Message-ID: <20190906214037.63e68b22@windsurf> (raw)
In-Reply-To: <20190906181844.60466-1-aduskett@gmail.com>

On Fri,  6 Sep 2019 11:18:44 -0700
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> Also:
>   Select PYTHON_SSL or PYTHON3_SSL as pip connects to https://pypi.org
>   making SSL mandatory for runtime.

Missing empty line before SoB line. But more importantly here you say
that you select PYTHON_SSL or PYTHON3_SSL, but...

> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/python-pip/Config.in       | 1 +
>  package/python-pip/python-pip.hash | 4 ++--
>  package/python-pip/python-pip.mk   | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/python-pip/Config.in b/package/python-pip/Config.in
> index ac741da872..805dc01545 100644
> --- a/package/python-pip/Config.in
> +++ b/package/python-pip/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PYTHON_PIP
>  	bool "python-pip"
>  	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
> +	select BR2_PACKAGE_PYTHON3_SSL

... you always select PYTHON3_SSL.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-09-06 19:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 18:18 [Buildroot] [PATCH 1/1] package/python-pip: bump to version 19.2.3 aduskett at gmail.com
2019-09-06 19:40 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906214037.63e68b22@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.