From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7B4C43331 for ; Sat, 7 Sep 2019 04:39:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCBEC208C3 for ; Sat, 7 Sep 2019 04:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389124AbfIGEjP (ORCPT ); Sat, 7 Sep 2019 00:39:15 -0400 Received: from verein.lst.de ([213.95.11.211]:34310 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387398AbfIGEjP (ORCPT ); Sat, 7 Sep 2019 00:39:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 95CBF68B05; Sat, 7 Sep 2019 06:39:11 +0200 (CEST) Date: Sat, 7 Sep 2019 06:39:11 +0200 From: Christoph Hellwig To: Paul Walmsley Cc: Christoph Hellwig , palmer@sifive.com, bp@alien8.de, mchehab@kernel.org, linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc Message-ID: <20190907043911.GA21510@lst.de> References: <20190818082935.14869-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, Sep 06, 2019 at 03:27:44PM -0700, Paul Walmsley wrote: > - Since the patch doesn't fix any bugs, there shouldn't be a Fixes: line. > Please let me know whether I can drop the line locally before I apply the > patch, or whether you'd like to resend it. It fixes the bug that we build code into a default RISC-V image that we absolutely should not. And it fixes the bug that the patch placed code in absolutely the wrong place. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9F4C43331 for ; Sat, 7 Sep 2019 04:39:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F043F20854 for ; Sat, 7 Sep 2019 04:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QUduIM3+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F043F20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6/uIvO0j74h00R/19UFrhgwPtAMrtue4T+UsyOIAQfw=; b=QUduIM3+9xjLl6 HLVHW2m+QeHTolSEYsZXM0aptEWRdVfwNsPLV2ZdR3gvrBPlSCHyOolN3F6GsaQoN+Jfp2wF/pBTG zOi/px0uDRw5duzE/x26rJ+LHr+jdM/pkOH95IjegQs8wYcK03Pm4v0FK9wdMtmSeu8tAjhed9DvB EvjuicuI4hGHoeur+AuufIIGJlnWrYivDRefS+gb9N7NU04yUMCn6NBm5soue0iyggB+9NuHSyzH4 q03XpXgsP5l/vHzomKAnlH3EptaQvfYSEnSSsMu7V5ColJZFLSUOJ0yMs3inRfVqTGq8N1EghczmR dWwrjxTpYAX3SESUzppQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6SVN-0004mT-EE; Sat, 07 Sep 2019 04:39:21 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i6SVI-0004bE-K8 for linux-riscv@lists.infradead.org; Sat, 07 Sep 2019 04:39:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 95CBF68B05; Sat, 7 Sep 2019 06:39:11 +0200 (CEST) Date: Sat, 7 Sep 2019 06:39:11 +0200 From: Christoph Hellwig To: Paul Walmsley Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc Message-ID: <20190907043911.GA21510@lst.de> References: <20190818082935.14869-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_213916_814166_8E4B58C6 X-CRM114-Status: UNSURE ( 8.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: palmer@sifive.com, linux-kernel@vger.kernel.org, bp@alien8.de, linux-riscv@lists.infradead.org, mchehab@kernel.org, Christoph Hellwig , linux-edac@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Sep 06, 2019 at 03:27:44PM -0700, Paul Walmsley wrote: > - Since the patch doesn't fix any bugs, there shouldn't be a Fixes: line. > Please let me know whether I can drop the line locally before I apply the > patch, or whether you'd like to resend it. It fixes the bug that we build code into a default RISC-V image that we absolutely should not. And it fixes the bug that the patch placed code in absolutely the wrong place. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv