From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package:gmp: enable C++ support when BR2_INSTALL_LIBSTDCPP=y
Date: Sat, 7 Sep 2019 15:04:08 +0200 [thread overview]
Message-ID: <20190907150408.1fb6b015@windsurf> (raw)
In-Reply-To: <1567690842-33954-1-git-send-email-gwenj@trabucayre.com>
Hello,
On Thu, 5 Sep 2019 15:40:40 +0200
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> gmp has a optional and disable by default, option to add C++ support.
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
The correct prefix in the commit title is "package/gmp:", not
"package:gmp:".
> +ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> +GMP_CONF_OPTS += --enable-cxx
> +endif
We like to have an explicit --disable-cxx in an else clause.
I fixed both issues and applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-07 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 13:40 [Buildroot] [PATCH] package:gmp: enable C++ support when BR2_INSTALL_LIBSTDCPP=y Gwenhael Goavec-Merou
2019-09-05 13:40 ` [Buildroot] [PATCH] package:gnuradio: bump to 3.8.0.0 Gwenhael Goavec-Merou
2019-09-05 13:40 ` [Buildroot] [PATCH] package:gnuradio: move to python3 Gwenhael Goavec-Merou
2019-09-07 20:46 ` Arnout Vandecappelle
2019-09-07 20:20 ` [Buildroot] [PATCH] package:gnuradio: bump to 3.8.0.0 Arnout Vandecappelle
2019-09-07 13:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907150408.1fb6b015@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.