From: Jonathan Cameron <jic23@kernel.org>
To: Pascal Bouwmann <bouwmann@tau-tec.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core
Date: Sun, 8 Sep 2019 13:13:58 +0100 [thread overview]
Message-ID: <20190908131358.7cedb1bf@archlinux> (raw)
In-Reply-To: <bcb0af95-94d4-eb15-0918-8d35b376da8e@tau-tec.de>
On Thu, 29 Aug 2019 07:29:41 +0200
Pascal Bouwmann <bouwmann@tau-tec.de> wrote:
> The center temperature of the supported devices stored in the constant
> BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
>
> Signed-off-by: Pascal Bouwmann <bouwmann@tau-tec.de>
Your patch is corrupted, but I've manually applied it.
I haven't marked it for stable because I worry a little that this will give
people unexpected changes in long term trends. Better they see that only
on a major kernel version upgrade.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> In the datasheet of the BMC150 device the center temperature is given
> wrongly.
> See https://community.bosch-sensortec.com/t5/MEMS-sensors-forum/
> center-temperature-of-bmc150-device/td-p/9328
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c
> b/drivers/iio/accel/bmc150-accel-core.c
> index 807299dd45eb..7e86a5b7ec4e 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -125,7 +125,7 @@
> #define BMC150_ACCEL_SLEEP_1_SEC 0x0F
>
> #define BMC150_ACCEL_REG_TEMP 0x08
> -#define BMC150_ACCEL_TEMP_CENTER_VAL 24
> +#define BMC150_ACCEL_TEMP_CENTER_VAL 23
>
> #define BMC150_ACCEL_AXIS_TO_REG(axis) (BMC150_ACCEL_REG_XOUT_L +
> (axis * 2))
> #define BMC150_AUTO_SUSPEND_DELAY_MS 2000
>
prev parent reply other threads:[~2019-09-08 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 5:29 [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core Pascal Bouwmann
2019-09-08 12:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908131358.7cedb1bf@archlinux \
--to=jic23@kernel.org \
--cc=bouwmann@tau-tec.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.