From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67174C433EF for ; Mon, 9 Sep 2019 09:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3859A218AC for ; Mon, 9 Sep 2019 09:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568022948; bh=jdkNyv/gG06Sh67/s+iuQnDbKorGXVGoFEBp4pU3fwI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=snmrlYjaq9Ith9jngcIJ/zDNVhRA5fhTB6GFc/sSfYS7T4LNuyhQQlYus5hF2QH/J EpO4yUS0ahHTv87HiUyAb7YG4h9YofNRDbqE7WKD2Gh5sdMstudMrjqoHCSMv/sPq+ iwm6oUdBrOx2irjtIbsprKxBDBuTWNHqevcCBDbw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390043AbfIIJzr (ORCPT ); Mon, 9 Sep 2019 05:55:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729219AbfIIJzr (ORCPT ); Mon, 9 Sep 2019 05:55:47 -0400 Received: from localhost (110.8.30.213.rev.vodafone.pt [213.30.8.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E2062086D; Mon, 9 Sep 2019 09:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568022946; bh=jdkNyv/gG06Sh67/s+iuQnDbKorGXVGoFEBp4pU3fwI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrJqT/DjmGhfIb7VVXiETRpZBT18NXPR9mwETfjW86Q48Xtej/TiAPfQbOHps1KC1 Aix08xtASO9FYqbst/DinNdM1VzumX6kLhoLwk3ZLHj5lm5SgapCZq74czbcFwiAjk O+pXcTDjY3wTiaByw2DOMW+gsCfXaL0xf9b3fQU4= Date: Mon, 9 Sep 2019 10:55:43 +0100 From: Greg Kroah-Hartman To: Yoshihiro Shimoda Cc: Veeraiyan Chidambaram , "linux-usb@vger.kernel.org" , Andrew Gabbasov , "REE erosca@DE.ADIT-JV.COM" , Felipe Balbi , Geert Uytterhoeven , Linux-Renesas Subject: Re: [PATCH v2 1/3] usb: renesas_usbhs: enable DVSE interrupt Message-ID: <20190909095543.GA17624@kroah.com> References: <1567771431-13235-1-git-send-email-external.veeraiyan.c@de.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Sep 09, 2019 at 07:02:46AM +0000, Yoshihiro Shimoda wrote: > Hi Veeraiyan, > > > From: Veeraiyan Chidambaram, Sent: Friday, September 6, 2019 9:04 PM > > > > From: Eugeniu Rosca > > > > Commit [1] enabled the possibility of checking the DVST (Device State > > Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling > > the irq_dev_state() handler if the DVST bit is set. But neither > > commit [1] nor commit [2] actually enabled the DVSE (Device State > > Transition Interrupt Enable) bit in the INTENB0 (Interrupt Enable > > Register 0). As a consequence, irq_dev_state() handler is getting > > called as a side effect of other (non-DVSE) interrupts being fired, > > which definitely can't be relied upon, if DVST notifications are of > > any value. > > > > Why this doesn't hurt is because usbhsg_irq_dev_state() currently > > doesn't do much except of a dev_dbg(). Once more work is added to > > the handler (e.g. detecting device "Suspended" state and notifying > > other USB gadget components about it), enabling DVSE becomes a hard > > requirement. Do it in a standalone commit for better visibility and > > clear explanation. > > > > [1] f1407d5 ("usb: renesas_usbhs: Add Renesas USBHS common code") > > [2] 2f98382 ("usb: renesas_usbhs: Add Renesas USBHS Gadget") > > > > Signed-off-by: Eugeniu Rosca > > I think your Signed-off-by is needed here and patch 2/3. Yes, I can't take this as-is without that. thanks, greg k-h