From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66870C4740A for ; Mon, 9 Sep 2019 14:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45051206CD for ; Mon, 9 Sep 2019 14:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfIIOyh (ORCPT ); Mon, 9 Sep 2019 10:54:37 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:45696 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbfIIOyh (ORCPT ); Mon, 9 Sep 2019 10:54:37 -0400 Received: from localhost (mehrangarh.blr.asicdesigners.com [10.193.185.169]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x89EsXFx027891; Mon, 9 Sep 2019 07:54:34 -0700 Date: Mon, 9 Sep 2019 20:24:32 +0530 From: Potnuri Bharat Teja To: Bernard Metzler Cc: "linux-rdma@vger.kernel.org" , "dledford@redhat.com" Subject: Re: [PATCH v1 rdma-next] RDMA/siw: Relax from kmap_atomic() use in TX path Message-ID: <20190909145427.GA12481@chelsio.com> References: <20190909132945.30462-1-bmt@zurich.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190909132945.30462-1-bmt@zurich.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Monday, September 09/09/19, 2019 at 18:59:45 +0530, Bernard Metzler wrote: > Since the transmit path is never executed in an atomic > context, we do not need kmap_atomic() and can always > use less demanding kmap(). > > Signed-off-by: Bernard Metzler > --- > drivers/infiniband/sw/siw/siw_qp_tx.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c > index 8e72f955921d..5d97bba0ce6d 100644 > --- a/drivers/infiniband/sw/siw/siw_qp_tx.c > +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c > @@ -76,16 +76,15 @@ static int siw_try_1seg(struct siw_iwarp_tx *c_tx, void *paddr) > if (unlikely(!p)) > return -EFAULT; > > - buffer = kmap_atomic(p); > + buffer = kmap(p); > > if (likely(PAGE_SIZE - off >= bytes)) { > memcpy(paddr, buffer + off, bytes); > - kunmap_atomic(buffer); missing kunmap() > } else { > unsigned long part = bytes - (PAGE_SIZE - off); > > memcpy(paddr, buffer + off, part); > - kunmap_atomic(buffer); > + kunmap(p); kunmap(buffer) > > if (!mem->is_pbl) > p = siw_get_upage(mem->umem, > @@ -97,11 +96,10 @@ static int siw_try_1seg(struct siw_iwarp_tx *c_tx, void *paddr) > if (unlikely(!p)) > return -EFAULT; > > - buffer = kmap_atomic(p); > - memcpy(paddr + part, buffer, > - bytes - part); > - kunmap_atomic(buffer); > + buffer = kmap(p); > + memcpy(paddr + part, buffer, bytes - part); > } > + kunmap(p); Can this be out of if()? the buffers seem to be different. > } > } > return (int)bytes; > -- > 2.17.2 >